Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding magmom and magmoms to implemented properties. Can be read from… #61

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions examples/socket/singlepoint/spin-polarized/run.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Using SPARC
from sparc.calculator import SPARC
from ase.build import molecule
import numpy as np

water = molecule('H2O', vacuum=7)
water.pbc = [False,False,False]
water.set_initial_magnetic_moments([0.1, 0.1, 0.1])

calc_params = {
"EXCHANGE_CORRELATION": "GGA_PBE",
"KPOINT_GRID": [1,1,1],
"MESH_SPACING": 0.35,
"TOL_SCF": 0.0001,
"MAXIT_SCF": 100,
"ELEC_TEMP_TYPE": "fermi-dirac",
"ELEC_TEMP": 116,
"PRINT_RESTART_FQ": 10,
"PRINT_ATOMS": 1,
"PRINT_FORCES": 1,
"SPIN_TYP": 1,
}

with SPARC(use_socket=True, **calc_params) as calc:
water.calc = calc
print("Initial magnetic moments before calculation call:\n", water.get_initial_magnetic_moments())
# energy = water.get_potential_energy()
# forces = water.get_forces()
net_magmom = water.get_magnetic_moment()
magmoms = water.get_magnetic_moments()
# print('***********************************************************************************************')
# print("Energy: {}\nMax Force: {}".format(energy, np.max(abs(forces)) ) )
print('*'*100)
print("Net magnetic moment: ", net_magmom)
print("Atomic magnetic moments:\n", magmoms)
6 changes: 6 additions & 0 deletions sparc/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,12 @@ def _extract_static_results(self, raw_results, index=":"):
if "forces" in static_results:
partial_results["forces"] = static_results["forces"][self.resort]

if "atomic_magnetization" in static_results:
partial_results["magmoms"] = static_results["atomic_magnetization"][self.resort]

if "net_magnetization" in static_results:
partial_results["magmom"] = static_results["net_magnetization"]

if "stress" in static_results:
partial_results["stress"] = static_results["stress"]

Expand Down
3 changes: 2 additions & 1 deletion sparc/sparc_parsers/atoms.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ def atoms_to_dict(
block_dict["COORD"] = pos
if write_spin:
# TODO: should we process atoms with already calculated magmoms?
block_dict["SPIN"] = p_atoms.get_initial_magnetic_moments()
n_atom = len(p_atoms)
block_dict["SPIN"] = p_atoms.get_initial_magnetic_moments().reshape(n_atom,-1)
if write_relax:
relax_this_block = relax_mask[start:end]
block_dict["RELAX"] = relax_this_block
Expand Down
3 changes: 2 additions & 1 deletion sparc/sparc_parsers/ion.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ def _write_ion(
"PSEUDO_POT",
"COORD_FRAC",
"COORD",
"SPIN",
"RELAX",
]:
val = block.get(key, None)
Expand All @@ -139,7 +140,7 @@ def _write_ion(
# TODO: make sure 1 line is accepted
# TODO: write pads to vector lines
if (val_string.count("\n") > 0) or (
key in ["COORD_FRAC", "COORD", "RELAX"]
key in ["COORD_FRAC", "COORD", "RELAX", "SPIN"]
):
output = f"{key}:\n{val_string}\n"
else:
Expand Down
3 changes: 3 additions & 0 deletions sparc/sparc_parsers/out.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ def _read_scfs(contents):
elif unit == "sec":
converted_value = raw_value * 1
converted_unit = "sec"
elif unit == "Bohr magneton":
converted_value = raw_value
converted_unit = "Bohr magneton"
else:
warn(f"Conversion for unit {unit} unknown! Treat as unit")
converted_value = raw_value
Expand Down
8 changes: 8 additions & 0 deletions sparc/sparc_parsers/static.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ def _read_static_block(raw_block):
name = "free energy"
elif "Atomic forces" in header_name:
name = "forces"
elif "Net magnetization" in header_name:
name = "net_magnetization"
elif "Atomic magnetization" in header_name:
name = "atomic_magnetization"
elif "Stress (GPa)" in header_name:
name = "stress"
elif "Stress equiv." in header_name:
Expand Down Expand Up @@ -149,6 +153,10 @@ def _read_static_step(step):
value = raw_value * Hartree
elif name == "forces":
value = raw_value * Hartree / Bohr
elif name == "atomic_magnetization":
value = raw_value
elif name == "net_magnetization":
value = raw_value
elif name == "stress":
# Stress is in eV/Ang^3, may need to convert to Virial later when cell is known
# For low-dimension stress info, use stress_equiv
Expand Down
Loading