[FEAT] 동네인증 프로세스 UI (#21) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
approved these changes
Jan 15, 2025
| @main | ||
| class AppDelegate: UIResponder, UIApplicationDelegate { | ||
|
|
||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | ||
| // Override point for customization after application launch. | ||
| // NMFAuthManager.shared().clientId = Config.nMapClientKey |
There was a problem hiding this comment.
네이버 클라이언트 키 가져오는 거였는데 다른 방식으로 해서 지워야 합니다 !!! 지워놓을게용
Comment on lines
+42
to
+47
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(false) | ||
|
|
||
| self.tabBarController?.tabBar.isHidden = true | ||
| moveCameraToLocation(latitude: coordinate.latitude, longitude: coordinate.longitude) | ||
| } |
There was a problem hiding this comment.
🐿️🐿️ 혹시 moveCameraToLocation(latitude: longitude:)가 네이버지도에서 현 위치 파악해서 화면 이동 및 확대하는 로직 맞을까요?!
지도 호출 시간이 꽤 길 것 같은데, viewWillAppear에서 지도를 로드하기 시작한다면 사용자가 오래 기다려야 할 것 같아요.
대기 시간을 줄이기 위해 viewDidLoad에서 호출하면 어떨까요?
There was a problem hiding this comment.
넹 맞습니다
viewDidLoad는 한 번만 불려서 뷰가 한 번 로드된 후엔 다시 들어가도 안 불려서 거기서 호출하면 안 될 것 같아요 🥹
Comment on lines
19
to
21
| let localName = "동교동" | ||
|
|
||
| // MARK: - LifeCycle |
There was a problem hiding this comment.
🐿️ 별 건 아니지만.. MARK 위에 한 줄 더 띄우면 좋을 것 같슴다👍
Comment on lines
87
to
92
| @objc | ||
| func closeView() { | ||
| if let sceneDelegate = UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate { | ||
| sceneDelegate.window?.rootViewController = ACTabBarController() | ||
| } | ||
| } |
There was a problem hiding this comment.
🐿️ 모달을 닫을 때 dismiss 메소드 대신 sceneDelegate에 접근하는 이유가 궁금합니다!
There was a problem hiding this comment.
앗 이게 모달을 닫을 때가 아니라, 시작하기 버튼을 눌렀을 때 탭바로 이동하는 로직입니다 !!
네이밍 수정하겠습니다 ㅠㅠ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
동네인증 프로세스 UI를 구현했습니다.
🚨 참고 사항
바텀시트 핸들러 세팅하는 메소드인 setHandlerImageView() BaseView에 만들어 두었습니다 ! @yurim830
지도 전 뷰에서 현재 위치를 가져오고 네이버지도로 넘기는 방식으로 구현해두었는데, 실기기에서 시간이 꽤 걸리는 것 같아요..
더 좋은 로직을 생각해보겠습니다.
📸 스크린샷
💥 To be sure
🌰 Resolve issue