Feat(client): 타임테이블 플로팅 컴포넌트 제작 #90
Open
+376
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏴☠️ Storybook 확인: 🔗 https://677bd6bc4909f2f48f4e0f42-lsykgcjtvt.chromatic.com/ |
gwagjiug
approved these changes
Jan 15, 2025
|
|
||
| interface RenderActionButtonProps { | ||
| variant: 'close' | 'edit' | 'complete'; | ||
| icon: JSX.Element; |
There was a problem hiding this comment.
👍굿입니다 React.Node 보다 JSX가 더 적절한 것 같긴해요
Comment on lines
51
to
53
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', |
There was a problem hiding this comment.
이 부분은 display 에 토큰화 동일하게 되어있습니다 flexCenter 쓰시면 좋을 것 같아요
bongtta
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
타임테이블 플로팅 컴포넌트를 제작했어요.
📚 Tasks
👀 To Reviewer
추후에는 EditFloatingButton를 렌더링하는 페이지에서 편집/삭제 모드 관련 상태를 제어해 줘야할 것 같아요.
해당 부분 감안해서 리뷰 부탁드릴게요 !
📸 Screenshot
2025-01-16.2.42.13.mov