Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(design-system): 홈 배너 상단 캐러셀 구현 #80

Merged
merged 18 commits into from
Jan 16, 2025
Merged

Feat(design-system): 홈 배너 상단 캐러셀 구현 #80

merged 18 commits into from
Jan 16, 2025
+582 −11

Conversation

seueooo
Copy link
Contributor

@seueooo seueooo commented Jan 14, 2025 •
edited
Loading

📌 Summary

📚 Tasks

  • 홈 배너 상단 무한 캐러셀 구현

👀 To Reviewer

  • 리액트 slick 라이브러리를 이용하여 구현했습니다 !
  • Slick의 기본 스타일을 사용하되, 바닐라 익스트랙트로 필요한 스타일만 오버라이드 하여 추가적인 커스터마이징을 진행했습니다.
  • useEffect와 setInterval을 사용해 4초 간격으로 자동 슬라이드 전환 기능을 추가
  • 현재 슬라이드의 공연 날짜, 제목, 부제목을 banner-title 섹션에서 동적으로 업데이트
  • settings 객체에 슬라이더의 동작을 정의

📸 Screenshot

2025-01-15.8.25.25.mov

@seueooo seueooo added ✨ Feature 기능 개발 한서 🎤 한서 labels Jan 14, 2025
@seueooo seueooo self-assigned this Jan 14, 2025
@seueooo seueooo requested a review from a team as a code owner January 14, 2025 16:03
@seueooo seueooo requested review from gwagjiug, m2na7, daahyunk and bongtta and removed request for a team January 14, 2025 16:03
@seueooo seueooo linked an issue Jan 14, 2025 that may be closed by this pull request
[Feature]: 상단 홈배너 컴포넌트 제작 #64
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

🏴‍☠️ Storybook 확인: 🔗 https://677bd6bc4909f2f48f4e0f42-zbokhufthv.chromatic.com/

@seueooo seueooo changed the title Feat: 홈 배너 상단 캐러셀 구현 Feat(design-system): 홈 배너 상단 캐러셀 구현 Jan 15, 2025
@m2na7
Copy link
Member

m2na7 commented Jan 15, 2025

리뷰어들이 이해하기 힘든부분이 많이 있어보이는데 PR에 설명좀부탁드릴게요 ! 그리고 동영상 첨부 부탁드려요 @seueooo

@seueooo
Copy link
Contributor Author

seueooo commented Jan 15, 2025

리뷰어들이 이해하기 힘든부분이 많이 있어보이는데 PR에 설명좀부탁드릴게요 ! 그리고 동영상 첨부 부탁드려요 @seueooo

pr 내용 추가하고 css 모두 vanila-extract 적용한걸로 바꿨습니다!

m2na7
m2na7 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@m2na7 m2na7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

gwagjiug
gwagjiug approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@gwagjiug gwagjiug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다 리뷰 확인해주세용

packages/design-system/src/components/top-carousel/top-carousel.css.ts Outdated Show resolved Hide resolved
packages/design-system/src/components/top-carousel/top-carousel.css.ts Show resolved Hide resolved
m2na7
m2na7 requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@m2na7 m2na7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~
VE로 변경하면서 디자인 토큰 적용이 많이 안된 것 같은데 지욱님이랑 제 리뷰참고하셔서 반영 부탁드려요 !

packages/design-system/src/components/top-carousel/dots.css.ts Outdated Show resolved Hide resolved
packages/design-system/src/components/top-carousel/dots.css.ts Outdated Show resolved Hide resolved
packages/design-system/src/components/top-carousel/slick.css.ts Outdated Show resolved Hide resolved
packages/design-system/src/components/top-carousel/top-carousel.stories.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/top-carousel/top-carousel.tsx Outdated Show resolved Hide resolved
m2na7
m2na7 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@m2na7 m2na7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 고생하셨어요 ~

@seueooo seueooo merged commit 925f9b3 into develop Jan 16, 2025
4 checks passed
@seueooo seueooo deleted the feat/home-banner-top/#64 branch January 16, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m2na7 m2na7 m2na7 approved these changes

@gwagjiug gwagjiug gwagjiug approved these changes

@daahyunk daahyunk Awaiting requested review from daahyunk daahyunk is a code owner automatically assigned from SOPT-all/35-appjam-web-confeti

@bongtta bongtta Awaiting requested review from bongtta bongtta is a code owner automatically assigned from SOPT-all/35-appjam-web-confeti

Assignees

@seueooo seueooo

Labels
✨ Feature 기능 개발 한서 🎤 한서
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: 상단 홈배너 컴포넌트 제작
3 participants
@seueooo @m2na7 @gwagjiug