Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#203] 웹파트 내부 QA 3차 수정 #204

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

thisishwarang
Copy link
Collaborator

📌 관련 이슈번호


체크리스트

  • 🎋 base 브랜치를 develop 브랜치로 설정했나요?
  • 🖌️ PR 제목은 형식에 맞게 잘 작성했나요?
  • 🏗️ 빌드는 성공했나요? (yarn build)
  • 🧹 불필요한 코드는 제거했나요? e.g. console.log
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • 🏷️ 라벨은 등록했나요?

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 지도뷰 SelectedStoreModal 스타일 수정
  2. 유저의 name, email 받아오는 api 훅 401에러 처리
  3. 로그아웃 api 훅에 queryClient.clear() 추가

📢 To Reviewers


📸 스크린샷 or 실행영상

Copy link
Collaborator

@youtheyeon youtheyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

끝이 보인다...🥹 너무 고생하셨습니다!!!

return useMutation({
mutationFn: deleteLogout,
onSuccess: () => {
queryClient.clear();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 감사해요 너무 굿 🫡

Comment on lines +94 to +97
if (!isLoggedIn()) {
openModal();
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 됐을 때만 모달 띄우고 return 해주는 거 너무 좋은 것 같습니다!

Copy link
Collaborator

@zzz-myam zzz-myam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Collaborator

@chaeneey chaeneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 안했을 때 처리를 꼼꼼하게 해주셔서 좋네요 .. 고생하셨습니다 !!

@thisishwarang thisishwarang merged commit 393a005 into develop Jan 23, 2025
1 of 3 checks passed
@thisishwarang thisishwarang deleted the fix/#203/web-qa-3 branch January 23, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 웹파트 내부 QA 3차 수정
4 participants