Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#175] 로그아웃 API 연결 #176

Merged
merged 4 commits into from
Jan 22, 2025
Merged

[Feat/#175] 로그아웃 API 연결 #176

merged 4 commits into from
Jan 22, 2025

Conversation

thisishwarang
Copy link
Collaborator

📌 관련 이슈번호

체크리스트

  • 🎋 base 브랜치를 develop 브랜치로 설정했나요?
  • 🖌️ PR 제목은 형식에 맞게 잘 작성했나요?
  • 🏗️ 빌드는 성공했나요? (yarn build)
  • 🧹 불필요한 코드는 제거했나요? e.g. console.log
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • 🏷️ 라벨은 등록했나요?

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 로그아웃 api 연결 했습니다.
  2. Loading 컴포넌트 퍼블리싱 했습니다.
  3. 비로그인시 마이페이지 들어갔을 때 에러터져서 에러바운더리로 잡히지 않도록 catch해서 처리해줬습니다.

📢 To Reviewers

📸 스크린샷 or 실행영상

@thisishwarang thisishwarang self-assigned this Jan 22, 2025
zzz-myam
zzz-myam approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@zzz-myam zzz-myam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그아웃 코드까지 이렇게 금방 뚝딱 만드시다니!! 역시 천재 리드는 뭔가 달라도 다르네요!

chaeneey
chaeneey approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@chaeneey chaeneey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩🤩🤩🤩🤩 고생하셨습니다 ~~ 제 로딩페이지까지 만들어주셔서 감사해요 ~~

youtheyeon
youtheyeon approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@youtheyeon youtheyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다운로드

@thisishwarang thisishwarang merged commit 16826d3 into develop Jan 22, 2025
1 check failed
@thisishwarang thisishwarang deleted the feat/#175/Logout branch January 22, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzz-myam zzz-myam zzz-myam approved these changes

@youtheyeon youtheyeon youtheyeon approved these changes

@chaeneey chaeneey chaeneey approved these changes

Assignees

@thisishwarang thisishwarang

Labels
✨ feature 기능 개발 👻 화랑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 로그아웃 API 연결
4 participants
@thisishwarang @chaeneey @youtheyeon @zzz-myam