[Feat/#138] 카카오로그인 구현 완료 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzz-myam
approved these changes
Jan 20, 2025
youtheyeon
approved these changes
Jan 20, 2025
| const Redirection = () => { | ||
| const code: string = | ||
| new URL(window.location.href).searchParams.get('code') || ''; | ||
| window.history.forward(); |
There was a problem hiding this comment.
goHome을 작성해준다면 forward()는 불필요할 것 같습니다!
There was a problem hiding this comment.
로그인 성공시 사용자가 브라우저 뒤로가기를 했을 때 카카오로그인 관련 url로 되돌아 가는것을 방지하기 위함입니다!!
src/utils/auth.ts
Outdated
| }; | ||
|
|
||
| export const isLoggedIn = () => { | ||
| return getToken() ? true : false; |
There was a problem hiding this comment.
어차피 true 또는 false로 반환되는 거면 삼항연산자보다 Boolean 함수가 더 적절해보입니다..!
return Boolean(getToken());은 어떠신가요 🤔
There was a problem hiding this comment.
좋네요! 반영하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈번호
체크리스트
✅ Key Changes
📢 To Reviewers
📸 스크린샷 or 실행영상