Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#123] 이미지 전체보기 모달 구현 #124

Merged
merged 2 commits into from
Jan 18, 2025
Merged

[Feat/#123] 이미지 전체보기 모달 구현 #124

merged 2 commits into from
Jan 18, 2025

Conversation

youtheyeon
Copy link
Collaborator

@youtheyeon youtheyeon commented Jan 18, 2025 •
edited
Loading

📌 관련 이슈번호

체크리스트

  • 🎋 base 브랜치를 develop 브랜치로 설정했나요?
  • 🖌️ PR 제목은 형식에 맞게 잘 작성했나요?
  • 🏗️ 빌드는 성공했나요? (yarn build)
  • 🧹 불필요한 코드는 제거했나요? e.g. console.log
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • 🏷️ 라벨은 등록했나요?

✅ Key Changes

이번 PR에서 작업한 내용을 간략히 설명해주세요

  1. 이미지 전체보기 모달 구현
  2. routes/index.ts 파일에서 읽히지 않은 import 삭제

📢 To Reviewers

📸 스크린샷 or 실행영상

2025-01-19.3.45.35.mov

@youtheyeon youtheyeon self-assigned this Jan 18, 2025
zzz-myam
zzz-myam approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@zzz-myam zzz-myam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 전체보기 모달 구현도 완벽하게 해내신 서연님! 깔끔한 코드라 더 할 말이 없네요!!

CLOSEBUTTON 변수명이 아주 직관적이에요! 칭찬합니다! 서연님 짱!

thisishwarang
thisishwarang reviewed Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@thisishwarang thisishwarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!

@thisishwarang thisishwarang merged commit 5634da5 into develop Jan 18, 2025
3 checks passed
@thisishwarang thisishwarang deleted the feat/#123/image-modal branch January 18, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzz-myam zzz-myam zzz-myam approved these changes

@thisishwarang thisishwarang thisishwarang approved these changes

@chaeneey chaeneey Awaiting requested review from chaeneey

Assignees

@youtheyeon youtheyeon

Labels
☘️ 서연 ✨ feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 이미지 전체보기 모달 구현
3 participants
@youtheyeon @thisishwarang @zzz-myam