Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#69] 마이페이지 조회 API 연동 #75

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

yskim6772
Copy link
Member

Related issue 🛠

Work Description 📝

  • 마이페이지 조회 API 연동
  • 프로필 이미지 - 로컬 이미지 매핑

Screenshot 📸

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

  • 마이페이지 조회 API 연동하였습니당

@yskim6772 yskim6772 self-assigned this Jan 23, 2025
@yskim6772 yskim6772 added 💻 서버 통신 서버 통신 작업 🌻 윤서 yskim6772 labels Jan 23, 2025
Copy link
Member

@sayyyho sayyyho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이페이지까지 API 연동을 해주시다니 레전드 감사합니다..!

@@ -26,6 +31,7 @@ android {

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
buildConfigField("String", "BASE_URL", properties["base.url"].toString())
buildConfigField("String", "TOKEN", properties["token"].toString())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token 처리 완전 굿!

@@ -34,6 +35,7 @@ fun GalleryMainCardItem(
AsyncImage(
model = image,
contentDescription = null,
contentScale = ContentScale.Crop,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Comment on lines 12 to 18
fun getToken(): String {
return sharedPreferences.getString("token", TOKEN) ?: TOKEN
}

fun saveToken(token: String) {
sharedPreferences.edit().putString("token", token).apply()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

덕분에 편하게 테스트했습니다!

@@ -16,6 +17,7 @@ class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_PORTRAIT
window.addFlags(WindowManager.LayoutParams.FLAG_SECURE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

방지 굿

Copy link
Collaborator

@serioushyeon serioushyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 뷰를 아주 빠르게 다 쳐내는게 역시 윤서...😉 진짜 너무 고마워요 ㅜㅜㅜㅜㅜㅜ

@@ -114,13 +125,22 @@ private fun MyPageScreen(
.padding(horizontal = 20.dp, vertical = 20.dp),
horizontalArrangement = Arrangement.spacedBy(12.dp),
) {
Image(
painter = painterResource(R.drawable.ic_profile),
val profileImageResId = when (myPageInfo.profileImage) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿!!

…ID-WITHSUHYEON into feat/#69-my-page-api

# Conflicts:
#	app/src/main/java/com/sopt/withsuhyeon/data/di/ApiModule.kt
#	app/src/main/java/com/sopt/withsuhyeon/data/di/DataSourceModule.kt
#	app/src/main/java/com/sopt/withsuhyeon/data/di/RepositoryModule.kt
#	app/src/main/java/com/sopt/withsuhyeon/feature/home/HomeScreen.kt
#	app/src/main/res/values/strings.xml
@yskim6772 yskim6772 merged commit 6284f47 into develop Jan 24, 2025
@yskim6772 yskim6772 deleted the feat/#69-my-page-api branch January 24, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌻 윤서 yskim6772 💻 서버 통신 서버 통신 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 마이페이지 API 연동
3 participants