[FEAT/#64] 회원가입 ViewModel 작업 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskim6772
approved these changes
Jan 22, 2025
| import com.sopt.withsuhyeon.ui.theme.WithSuhyeonTheme.colors | ||
| import com.sopt.withsuhyeon.ui.theme.WithSuhyeonTheme.typography | ||
|
|
||
| @Composable | ||
| fun FinishRoute( | ||
| padding: PaddingValues, | ||
| navigateToNext: () -> Unit | ||
| navigateToNext: () -> Unit, | ||
| viewModel: SignUpViewModel |
There was a problem hiding this comment.
= hiltViewModel() 붙여줍시다 !
Comment on lines
+104
to
+106
| LaunchedEffect(Unit) { | ||
| viewModel.updateProgress(state.progress + 1f / 7) | ||
| } |
| @@ -129,6 +142,7 @@ fun SelectProfileScreen( | |||
| .alpha(if (profileImage == profileType.titleResId) 1f else 0.3f) | |||
| .noRippleClickable { | |||
| profileImage = profileType.titleResId | |||
| viewModel.updateProfileImage("image${index+1}") | |||
| @@ -78,7 +82,8 @@ fun NavGraphBuilder.onBoardingNavGraph( | |||
| onNavigateToPostProfileImage: () -> Unit, | |||
| onNavigateToSelectLocation: () -> Unit, | |||
| onNavigateToFinish: () -> Unit, | |||
| onNavigateToHome: () -> Unit | |||
| onNavigateToHome: () -> Unit, | |||
| getBackStackUploadViewModel: @Composable (NavBackStackEntry) -> SignUpViewModel | |||
serioushyeon
approved these changes
Jan 23, 2025
| @@ -96,6 +100,16 @@ fun MainNavHost( | |||
| onNavigateToSelectLocation = navigator::navigateToSelectLocation, | |||
| onNavigateToFinish = navigator::navigateToOnboardingFinish, | |||
| onNavigateToHome = navigator::navigateToHome, | |||
| getBackStackUploadViewModel = { navBackStackEntry -> | |||
Comment on lines
+104
to
+106
| LaunchedEffect(Unit) { | ||
| viewModel.updateProgress(state.progress + 1f / 7) | ||
| } |
| @@ -58,21 +65,22 @@ fun SelectLocationScreen( | |||
| ) | |||
| } | |||
| val subLocationList = remember { | |||
There was a problem hiding this comment.
지역 가져오는 것만 제거랑 추후에 합치면 좋을 것 같아요 넘 잘하셨습니다 ㅎㅎ
| ) | ||
| } | ||
| composable<OnboardingFinishRoute> { | ||
| FinishRoute( | ||
| navigateToNext = onNavigateToHome, | ||
| padding = padding | ||
| padding = padding, | ||
| viewModel = getBackStackUploadViewModel(it) |
There was a problem hiding this comment.
공유 뷰모델때문에 너무 고생하셨어요 ㅜㅡㅜ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description 📝
Screenshot 📸
Screen_Recording_20250123-015035_With-Suhyeon.1.mp4
Uncompleted Tasks 😅
To Reviewers 📢
회원가입 뷰모델 작업 완료했습니다! API 연결 가볼게요~