Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/#29] post bottom bar #31

Merged
merged 2 commits into from
Jan 17, 2025
Merged

[UI/#29] post bottom bar #31

merged 2 commits into from
Jan 17, 2025

Conversation

serioushyeon
Copy link
Collaborator

Related issue πŸ› 

Work Description πŸ“

  • κ²Œμ‹œλ¬Ό λ°”ν…€ λ°” κ΅¬ν˜„
  • string 넀이밍 λ³€κ²½
  • drawBehind 내뢀에 μ„ μ–Έν•œ border 컬러λ₯Ό μ™ΈλΆ€μ—μ„œ μ„ μ–Έν•˜μ—¬ colors μ‚¬μš© κ°€λŠ₯ν•˜λ„λ‘ μˆ˜μ •

Screenshot πŸ“Έ

image image

Uncompleted Tasks πŸ˜…

  • Task1

To Reviewers πŸ“’

LargeButtonμ—μ„œ μΈμžκ°€ isDisabledμ—¬μ„œ PostBottomBarμ—μ„œλ„ isDisabledλ₯Ό 받도둝 ν–ˆμŠ΅λ‹ˆλ‹€!
μ‚¬μ§„μ²˜λŸΌ κΈˆμ•‘μ΄ 길어지면 μ±„νŒ… λ²„νŠΌμ΄ 짧아지도둝 κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
isMyPost인자둜 λ‚΄ κ²Œμ‹œλ¬ΌμΈ 경우, λ‹€λ₯Έ μ‚¬λžŒ κ²Œμ‹œλ¬ΌμΈ 경우 각각 λ²„νŠΌμ˜ string이 λ°”λ€Œλ„λ‘ κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
λ˜ν•œ λ‚΄ κ²Œμ‹œλ¬ΌμΈ κ²½μš°μ—λŠ” isDisabledκ°€ false인 경우만 μ‘΄μž¬ν•΄μ•Όν•΄μ„œ μ œμ•½μ„ λ„£μ—ˆμŠ΅λ‹ˆλ‹€! (ν˜Ήμ—¬λ‚˜ μ‹€μˆ˜λ₯Ό λ°©μ§€ν•˜κΈ° μœ„ν•΄!)
λ‹€λ“€ ν™”μ΄νŒ…..

@serioushyeon serioushyeon added πŸ› οΈ [CHORE] 버전 μ½”λ“œ μˆ˜μ •, νŒ¨ν‚€μ§€ ꡬ쑰 λ³€κ²½, νƒ€μž… 및 λ³€μˆ˜λͺ… λ³€κ²½ λ“± (별거 μ•„λ‹Œ μž‘μ—…) πŸ’› COMPOSE Jetpack Compose둜 κ΅¬ν˜„ πŸ’™ [UI] UI μž‘μ—… πŸ€ μ§€ν˜„ serioushyeon labels Jan 16, 2025
@serioushyeon serioushyeon self-assigned this Jan 16, 2025
@serioushyeon serioushyeon changed the title UI/#29 post bottom bar [UI/#29] post bottom bar Jan 16, 2025
sayyyho
sayyyho approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@sayyyho sayyyho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ»΄ν¬λ„ŒνŠΈμ˜ μ‹ μ΄λ„€μš”!! κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

app/src/main/java/com/sopt/withsuhyeon/core/component/bottombar/PostBottomBar.kt
}
LargeButton(
text = buttonText,
isDisabled = if(isMyPost) false else isDisabled,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

yskim6772
yskim6772 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@yskim6772 yskim6772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§„μ§œ μ»΄ν¬λ„ŒνŠΈμ˜ μ‹ μž„ .. μ»΄μ‹  ,, κ³ μƒν–ˆμ–΄μš” !!

app/src/main/java/com/sopt/withsuhyeon/core/component/bottombar/PostBottomBar.kt
@Composable
fun PostBottomBar(
price: Int,
isMyPost: Boolean,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMyPost μ²˜λ¦¬κΉŒμ§€ κ΅Ώ !!

@serioushyeon serioushyeon merged commit 9d67d16 into develop Jan 17, 2025
@serioushyeon serioushyeon deleted the ui/#29-post-bottom-bar branch January 20, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskim6772 yskim6772 yskim6772 approved these changes

@sayyyho sayyyho sayyyho approved these changes

Assignees

@serioushyeon serioushyeon

Labels
πŸ€ μ§€ν˜„ serioushyeon πŸ› οΈ [CHORE] 버전 μ½”λ“œ μˆ˜μ •, νŒ¨ν‚€μ§€ ꡬ쑰 λ³€κ²½, νƒ€μž… 및 λ³€μˆ˜λͺ… λ³€κ²½ λ“± (별거 μ•„λ‹Œ μž‘μ—…) πŸ’› COMPOSE Jetpack Compose둜 κ΅¬ν˜„ πŸ’™ [UI] UI μž‘μ—…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] κ²Œμ‹œλ¬Ό λ°”ν…€ λ°” κ΅¬ν˜„
3 participants
@serioushyeon @sayyyho @yskim6772