[feat] component picker 구현 #32
Open
+442
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
학기 피커같은 경우에는 범위가 지정되어 있기도 하고, 현재 날짜에 따라 디폴트 설정값이 달라져야 합니다. 이 부분 기능 명세 한번 확인 부탁드려요! 없으면 티엘 선생님한테 여쭤보세요! 변경되는 플로우가 있다고 합니다. |
beom84
approved these changes
Jan 16, 2025
app/src/main/java/org/android/bbangzip/presentation/util/constant/DateConstant.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/android/bbangzip/presentation/component/wheelpicker/BbangZipPicker.kt
Show resolved
Hide resolved
app/src/main/java/org/android/bbangzip/presentation/component/wheelpicker/BbangZipPicker.kt
Show resolved
Hide resolved
app/src/main/java/org/android/bbangzip/presentation/component/wheelpicker/BbangZipPicker.kt
Outdated
Show resolved
Hide resolved
| Modifier | ||
| .onSizeChanged { size -> itemHeightPixels.intValue = size.height } | ||
| .padding(8.dp) | ||
| .then(textModifier), |
There was a problem hiding this comment.
text의 확장성을 확 늘려줍니다!
app/src/main/java/org/android/bbangzip/presentation/component/wheelpicker/BbangZipDatePicker.kt
Outdated
Show resolved
Hide resolved
beom84
reviewed
Jan 16, 2025
| @Composable | ||
| fun Picker( | ||
| items: List<String>, | ||
| state: MutableState<String>, |
There was a problem hiding this comment.
p2
상태 호이스팅을 하지않고 mutableState로 선언하신 이유가 있나요?
There was a problem hiding this comment.
상태 동기화 측면에서 MutableState를 전달하는 것이 더 좋다고 하여 처음엔 전달하게 되었습니다.
저희의 구조상 상태 흐름을 명확하게 해야 생각해서 바꾸도록 하겠습니다.
다른 분들은 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
datepicker.mp4
semesterPicker.mp4
Uncompleted Tasks 😅
To Reviewers 📢
현재 시각 8:23 기능적으로는 구현이 된것 같지만 확장성, 유지보수 측면에서 제대로 못했을 수 있으니 잘 봐주십쇼!