Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Bottom Sheet 컴포넌트 구현 #27

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

[feat] Bottom Sheet 컴포넌트 구현 #27

wants to merge 10 commits into from

Conversation

HAJIEUN02
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 commented Jan 15, 2025 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • BbangZipBasicModalBottomSheet
  • BbangZipDatePickerBottomSheet
  • BbangZipListDefaultPickerBottomsheet
  • BbangZipListPickerBottomSheet
  • BbangZipOneButtonBottomSheet
  • BbangZipTwoButtonBottomSheet

Screenshot 📸

BbangZipBasicModalBottomSheet BbangZipDatePickerBottomSheet BbangZipListDefaultPickerBottomSheet
image image image
BbangZipListPickerBottomSheet BbangZipOneButtonBottomSheet BbangZipTwoButtonBottomSheet
image image image

Uncompleted Tasks 😅

  • 피커랑 버튼 머지되면 바텀시트에 집어넣어야 해요! 재민짱 빨리 해줘
  • PR 다 올리고 나서 생각난.. 뒷부분 클릭하면 바텀시트 내려가게 만들기..
  • 승범오빠가 만든 확장함수 clickable에 적용하기..

To Reviewers 📢

고생핑

@HAJIEUN02 HAJIEUN02 added this to the 전체 컴포넌트 구현 milestone Jan 15, 2025
@HAJIEUN02 HAJIEUN02 self-assigned this Jan 15, 2025
@HAJIEUN02 HAJIEUN02 requested a review from a team as a code owner January 15, 2025 12:55
beom84
beom84 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@beom84 beom84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

...ava/org/android/bbangzip/presentation/component/bottomsheet/BbangZipDatePickerBottomSheet.kt
isBottomSheetVisible: Boolean,
modifier: Modifier = Modifier,
bottomSheetTitle: String,
selectedDate: ExamDate? = null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3
selectedData는 null 값을 보유할 일이 없어서 Elvis 연산자는 빼도 좋을 것 같습니다

kamja0510
kamja0510 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@kamja0510 kamja0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

텍필 화이팅

...ava/org/android/bbangzip/presentation/component/bottomsheet/BbangZipBasicModalBottomSheet.kt

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun BbangZipBasicModalBottomSheet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5
얘정도면 슬롯이라해도 상관없겠죠?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마자여 슬롯 역할이에용가리

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beom84 beom84 beom84 approved these changes

@kamja0510 kamja0510 kamja0510 approved these changes

Assignees

@HAJIEUN02 HAJIEUN02

Labels
✨FEAT✨ 🐬지은🐬
Projects
None yet
Milestone
전체 컴포넌트 구현
Development

Successfully merging this pull request may close these issues.

[feat] Bottom Sheet 컴포넌트 구현
3 participants
@HAJIEUN02 @kamja0510 @beom84