Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[week6][정영훈] 과제 제출 #7

Open
wants to merge 1 commit into
base: yeonghun-week6
Choose a base branch
from

Conversation

Yeonghunj
Copy link

💎 과제 구현 설명

과제를 위해 사용했던 함수, 수정한 파일 등 구현 내용에 대한 간단한 설명을 작성해 주세요.

  • getImage 함수로 cat api를 통해 고양이 이미지를 불러왔습니다.

🏁 PR 체크리스트

  • [ o ] 코드가 오류 없이 정상적으로 실행되나요?
  • [ o ] 커밋 메시지 컨벤션(템플릿 활용)을 준수했나요?
  • [ o ] 과제 마감기한을 준수했나요?

🖼️ Screenshot / Video

image image

🙌 Issue

과제 수행 중 어려웠던 부분이나 궁금했던 점을 자유롭게 작성해 주세요.

@Yeonghunj Yeonghunj requested a review from seank021 April 29, 2024 12:01
@Yeonghunj Yeonghunj changed the title hw [week6][정영훈] 과제 제출 Apr 30, 2024
@eunjaelee1004
Copy link

우와 너무 수고하셨습니다!

Copy link

@seank021 seank021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!

// ### TO DO ###
// #############
const response = await axios.get(
"https://api.thecatapi.com/v1/images/search?limit=1&size=large",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit=1 등의 디폴트 파라미터는 굳이 안 써도 될 것 같아요!

Comment on lines +39 to +48
const imageSet = [];

data.map((e) => {
imageSet.push({
id: e.id,
url: e.url,
isFavourite: false,
favouriteId: null,
});
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어차피 사진 하나만 받아오는 거니까, 굳이 배열로 가지 않아도 될 것 같습니다!! (논리적으로 상관은 없음)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants