-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[week6][정영훈] 과제 제출 #7
base: yeonghun-week6
Are you sure you want to change the base?
Conversation
우와 너무 수고하셨습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!!
// ### TO DO ### | ||
// ############# | ||
const response = await axios.get( | ||
"https://api.thecatapi.com/v1/images/search?limit=1&size=large", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limit=1 등의 디폴트 파라미터는 굳이 안 써도 될 것 같아요!
const imageSet = []; | ||
|
||
data.map((e) => { | ||
imageSet.push({ | ||
id: e.id, | ||
url: e.url, | ||
isFavourite: false, | ||
favouriteId: null, | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어차피 사진 하나만 받아오는 거니까, 굳이 배열로 가지 않아도 될 것 같습니다!! (논리적으로 상관은 없음)
💎 과제 구현 설명
🏁 PR 체크리스트
🖼️ Screenshot / Video
🙌 Issue