Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI parameter for running without graphics #1551

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

tslocum
Copy link
Contributor

@tslocum tslocum commented Sep 23, 2023

Resolves #1547.

Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! an improvement idea: there may be more modes in the future, so instead of single flags, i think having a --mode=headless or --mode=full would be more future-proof :)

Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

The only thing missing is that you have to add your info to https://github.com/SFTtech/openage/blob/master/copying.md . Otherwise it'd be good to go.

You can try to implement @TheJJ 's suggestion. That would be a bit more tricky but more future proof if we add more modes.

@tslocum
Copy link
Contributor Author

tslocum commented Sep 23, 2023

I have added my info. I agree that expanding this is more future-proof, but will leave that to someone else when the need arises. Thank you both.

@heinezen
Copy link
Member

@tslocum Alright :)

Your info doesn't match up with the commit mail, so please change that and we can merge.

@heinezen
Copy link
Member

Also maybe do a rebase fro master while you are at it :D

@tslocum
Copy link
Contributor Author

tslocum commented Sep 24, 2023

Gladly. I think this is all fixed up now.

@TheJJ TheJJ merged commit bda929f into SFTtech:master Sep 26, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI parameter for engine start mode
3 participants