-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI parameter for running without graphics #1551
Conversation
c2a09e4
to
5e5e027
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! an improvement idea: there may be more modes in the future, so instead of single flags, i think having a --mode=headless or --mode=full would be more future-proof :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
The only thing missing is that you have to add your info to https://github.com/SFTtech/openage/blob/master/copying.md . Otherwise it'd be good to go.
You can try to implement @TheJJ 's suggestion. That would be a bit more tricky but more future proof if we add more modes.
5e5e027
to
0d3bd2f
Compare
I have added my info. I agree that expanding this is more future-proof, but will leave that to someone else when the need arises. Thank you both. |
@tslocum Alright :) Your info doesn't match up with the commit mail, so please change that and we can merge. |
Also maybe do a rebase fro master while you are at it :D |
0d3bd2f
to
fb531fc
Compare
Gladly. I think this is all fixed up now. |
Resolves #1547.