-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converter fixes + Release demos #1529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
lang: c++
Done in C++ code
lang: python
Done in Python code
area: assets
Involved with assets (images, sounds, ...)
labels
Aug 12, 2023
heinezen
force-pushed
the
release-demos
branch
3 times, most recently
from
August 16, 2023 00:39
538657e
to
467b7db
Compare
heinezen
force-pushed
the
release-demos
branch
4 times, most recently
from
August 29, 2023 18:11
f4b0a4b
to
4d7ec59
Compare
heinezen
force-pushed
the
release-demos
branch
from
September 5, 2023 14:31
ca41a93
to
c884f75
Compare
Avoids expensive Python calls when using Path objects as map keys.
'game' jumps right into a game, 'main' has more startup queries.
heinezen
force-pushed
the
release-demos
branch
from
September 28, 2023 14:52
b24a799
to
9a33715
Compare
TheJJ
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: assets
Involved with assets (images, sounds, ...)
lang: c++
Done in C++ code
lang: python
Done in Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the conversion issues for HD, DE1, DE2 and implements the engine demos for the next release.
Depends on #1525
bin/run
engine
if it's not exported yet (fixes Rise of Rome error: Requested modpack 'engine' not available. #1530 )