fix: applicant list and domain event handle null course

SEAD-UFES · Dec 22, 2022 · de6e9c5 · de6e9c5
1 parent 099a7d3
commit de6e9c5
Show file tree

Hide file tree

Showing 4 changed files with 587 additions and 503 deletions.
diff --git a/app/Listeners/DomainEventSubscriber.php b/app/Listeners/DomainEventSubscriber.php
@@ -112,16 +112,16 @@ public function handleBondReviewRequested(BondReviewRequested $event)
      */
     public function handleBondImpeded(BondImpeded $event)
     {
-        $secUsers = $this->userRepository->getActiveUsersOfActiveTypeId($this->secUtId);
+        $users = $this->userRepository->getActiveUsersOfActiveTypeId($this->secUtId);
 
         /**
-         * @var Course $course
+         * @var ?Course $course
          */
         $course = $event->bond->course;
-        $courseId = $course->id;
-        $coordUsers = $this->userRepository->getActiveUsersOfActiveTypeIdOfCourseId($this->coordUtId, $courseId);
-
-        $users = $secUsers->merge($coordUsers);
+        $courseId = $course?->id;
+        if ($courseId != null) {
+            $users->merge($this->userRepository->getActiveUsersOfActiveTypeIdOfCourseId($this->coordUtId, $courseId));
+        }
 
         Notification::send($users, new BondImpededNotification($event->bond));
         $this->logger->logDomainEvent(