Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Layout 컴포넌트 수정, Typo 컴포넌트 추가 #354

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

im-na0
Copy link
Contributor

@im-na0 im-na0 commented May 23, 2024

Issue Number

close

⛳️ Task

  • Layout 컴포넌트 변경
  • Typo 컴포넌트 추가

✍️ Note

1. Layout 컴포넌트 변경

  • bg 프로퍼티 추가 → 배경색 지정 가능
  • isHeaderOn, isBottomNavOn props 타입 옵셔널로 변경, default = false
  • Header 컴포넌트 text 프로퍼티 추가 → 헤더 타이틀을 text 프로퍼티 통해서 전달 가능

Layout을 좀 더 유연하게 수정할 수 있게끔 변경했습니다.

2. Typo 컴포넌트 추가

간단한 타이포그래피용 컴포넌트를 추가했습니다.

<Typo as="p" typo="body1" color="black">텍스트 입력</Typo>

Props

  • as?: ElementType default span
  • typo: TypoKeys
  • color?: ColorKeys default black
  • isEllipsis: boolean default false
  • textAlign?: CSSProperties["textAlign"]

📎 Reference

@im-na0 im-na0 added FEAT FEAT DESIGN DESIGN labels May 23, 2024
@im-na0 im-na0 self-assigned this May 23, 2024
Copy link

Visit the preview URL for this PR (updated for commit 9f2dcd0):

https://percenthotel--pr354-feature-352-common-cuf6liuj.web.app

(expires Thu, 30 May 2024 10:36:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 5f3aee9d8d8535dbb552ad12361bc813c5a90573

@im-na0 im-na0 merged commit 54ddd4b into main Jun 13, 2024
2 of 3 checks passed
@im-na0 im-na0 deleted the feature/#352-common-ui branch June 13, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DESIGN DESIGN FEAT FEAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant