-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop SimEnergyDeposits made by LArG4 in standard g4 workflow #206
Conversation
Looking at a file from last production I see the following
This PR would leave us with only:
I am happy with this but I'd also like to hear the thoughts of the SBN PDS and TPC Sim groups so I am adding them to the review for final sign off |
@ggamezdiego could you pass word along to Alessandro as well? |
Hi @jzennamo, thanks for summarizing! There is one more actually! This PR will leave us with
These are a copy of the largeant ones, but with the addition of electrons and photons. The outside-AV one doesn't have the |
right! Thanks for catching my ommission! |
trigger build |
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIs are as expected. I will wait on approval from the SBN PDS and TPC sim groups before merging.
Done! |
@mrmooney approved offline along with @gputnam, this is ready to be merged! Thanks @marcodeltutto! |
Fixes SBNSoftware/sbncode#185