Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop SimEnergyDeposits made by LArG4 in standard g4 workflow #206

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

marcodeltutto
Copy link
Member

@jzennamo
Copy link
Contributor

jzennamo commented Nov 5, 2021

Looking at a file from last production I see the following sim::SimEnergyDeposits:

sim::SimEnergyDeposits_ionandscint__G4.obj
sim::SimEnergyDeposits_ionandscint_priorSCE_G4.obj
sim::SimEnergyDeposits_ionandscintout__G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolCryostat_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolFieldCage_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolPDSstructure_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolPMT_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolTPCActive_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolTPCPlaneVert_G4.obj
sim::SimEnergyDeposits_largeant_LArG4DetectorServicevolXArapuca_G4.obj

This PR would leave us with only:

sim::SimEnergyDeposits_ionandscint_priorSCE_G4.obj

I am happy with this but I'd also like to hear the thoughts of the SBN PDS and TPC Sim groups so I am adding them to the review for final sign off

@jzennamo
Copy link
Contributor

jzennamo commented Nov 5, 2021

@ggamezdiego could you pass word along to Alessandro as well?

@marcodeltutto
Copy link
Member Author

Hi @jzennamo, thanks for summarizing! There is one more actually! This PR will leave us with

sim::SimEnergyDeposits_ionandscint_priorSCE_G4.obj    [energy deposit in AV]
sim::SimEnergyDeposits_ionandscintout__G4.obj         [energy deposit outside AV]

These are a copy of the largeant ones, but with the addition of electrons and photons.

The outside-AV one doesn't have the priorSCE label, but I understand we don't have SCE corrections outside the AV, so this is effectively a priorSCE collection. Please correct me if I'm wrong!

@jzennamo
Copy link
Contributor

jzennamo commented Nov 5, 2021

right! Thanks for catching my ommission!

@pgreen135
Copy link
Member

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Copy link
Member

@pgreen135 pgreen135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIs are as expected. I will wait on approval from the SBN PDS and TPC sim groups before merging.

@ggamezdiego
Copy link
Contributor

@ggamezdiego could you pass word along to Alessandro as well?

Done!

@jzennamo
Copy link
Contributor

jzennamo commented Nov 8, 2021

@mrmooney approved offline along with @gputnam, this is ready to be merged!

Thanks @marcodeltutto!

@marcodeltutto marcodeltutto added the enhancement New feature or request label Nov 8, 2021
@pgreen135 pgreen135 merged commit 4ba323c into develop Nov 9, 2021
@pgreen135 pgreen135 deleted the mdeltutt_sbncode_issue185 branch November 16, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimEnergyDeposit Collections in new LArG4
5 participants