fix(textarea): Focus Outline Touching Borders in Readonly Textarea #9759

tw4 · 2024-08-27T17:41:29Z

Related to Issue #9741 (issue 2)

nnaydenow · 2024-08-27T20:50:02Z

Hi @MapTo0,

Could you please review that PR?

Regards,
Nayden

nnaydenow · 2024-09-04T08:30:08Z

Hi @tw4,

Sorry for the delayed action.

Same fix need to be applied to packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css otherwise the issue will continue to exist in in sap_horizon_dark theme.

Could you also rebase your PR to the main branch in order receive the chromedriver update?

Regards,
Nayden

tw4 · 2024-09-04T09:55:39Z

Hello @nnaydenow,

Thank you very much for your feedback. I will make the necessary arrangements during the day.

Best regards.

Fixes: #9526

Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Issue: - Based on the template the open is set before the opener attribute resulting into a console warning. Fixes: #9708

…9744) FIXES: #9736

Fixes: #9438

* [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I7bac7b072d5556d66cd6d7ed416b01821d90f322 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I758f5450d2b92cd9f9c16a11d99b553b8c9257db * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I9e49d0549aefa5b9225633e659130e75188c3060 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ie875b1160b001dfe25e2a867ab4540f5743e8d0f * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I3c42c1a77208c0cee3624d624fa5cce1bd1fc668 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I45825b589c1ffdd2ff28ab0f3c5d35be90f141a8 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Iaf6eee2ab467884ee8b3dcf23613f526bdd319e9 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ia4382add28280ece69f101fa77f6bc377b0b0c57 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: Ia37170988b3d9b535791e094ff8d266e8830ce40 * [INTERNAL] Translation delivery: commit by LX Lab Change-Id: I3bdb2f685f8da883d736c45e3a2f2b95a2323d15

In chrome 128 new headless mode described in https://developer.chrome.com/docs/chromium/new-headless is set to be used by default. This made tests unstable. To make tests stable again we have to pass `old` as value to the `headless` parameter in Chrome configuration options.

…9680) This PR introduces Range Selection functionality for ui5-monthpicker and ui5-year-picker, to be used within the ui5-daterange-picker component. When the formatPattern of a DateRangePicker is set to a pattern that includes months and years or only years, users can now select a range directly within these views. Example Usage: - For month range selection, create a DateRangePicker as follows: <ui5-daterange-picker format-pattern="MM/yyyy"></ui5-daterange-pickerr> - Similarly for year range selection: <ui5-daterange-picker format-pattern="yyyy"></ui5-daterange-pickerr> More Info: - The selectionMode property is now available for MonthPicker and YearPicker, supporting "Single" or "Range" selection modes. - Addition for ui5-calendar: To customize the styling of the selected-between months or years in a range, use the month-cell-selected-between and year-cell-selected-between CSS parts. Fixes: #8177 Original PR: #8187

Previously, there were no visual indicators when hovering over a menu item, aside from the focus border. With this change, we're adding `hover` and `active` styles to the menu items.

Bumps [axios](https://github.com/axios/axios) from 1.6.2 to 1.7.5. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.6.2...v1.7.5) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

With component restructuring used solution no longer takes effect. Now, scrollbar overstyling is not added to the component adoptedStyleSheets if the `ui5-content-native-scrollbar` CSS class is added to the body element. Related to: #9720, #9695

FIXES: #9670 FIXES: #9571

Fixate the date, as some months are not filled correctly with special dates

removing public from documentation of private(internal) components

We are renaming the `fileSizeExceeded` event to `file-size-exceed` so it's consistent with the framework convention. If you were using it as: ```JS fileUploader.addEventListener("fileSizeExceeded", function (event) { alert("File is too big!"); } ``` You should now use it as: ```JS fileUploader.addEventListener("file-size-exceed", function (event) { alert("File is too big!"); } ```

Bumps [webpack](https://github.com/webpack/webpack) from 5.90.3 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.90.3...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Fixes: #9693

…9585) Co-authored-by: Petar Dimov <[email protected]>

fixes: #5203

…es (#9800) The base params used to be included only in the default theme (sap_horizon) and not included in the rest. By adding the params everything looks same in all themes. Fixes: #9788

Fixes: #9011

cla-assistant · 2024-09-04T15:20:49Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 13 committers have signed the CLA.

✅ nnaydenow
✅ unazko
✅ vladitasev
✅ TeodorTaushanov
✅ ilhan007
✅ tsanislavgatev
✅ tw4
✅ MapTo0
✅ hinzzx
✅ dimovpetar
❌ pskelin
❌ ui5-webcomponents-bot
❌ didip1000
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

nnaydenow requested a review from MapTo0 August 27, 2024 20:49

nnaydenow added the for review label Sep 4, 2024

nnaydenow added author action and removed for review labels Sep 4, 2024

nnaydenow and others added 23 commits September 4, 2024 18:18

fix(ui5-table): fix border and focus overlap (compat) (#9726)

7f889d1

Fixes: #9526

docs: fix compat table samples theming (#9765)

e9ab951

fix(ui5-color-palette-popover): set opener attribute (#9746)

1dbc226

Issue: - Based on the template the open is set before the opener attribute resulting into a console warning. Fixes: #9708

fix(ui5-multi-combobox): remove VS header after setting VH to None (#…

0cda01d

…9744) FIXES: #9736

chore: do not strip languages from CLDR assets (#9748)

ff3d878

fix(ui5-table): busy indicator overlay (compat) (#9737)

3ad93b4

Fixes: #9438

chore(release): publish v2.2.0-rc.3 [ci skip]

9fe96f1

fix(ui5-menu-item): add hover and active styles (#9774)

05d2003

Previously, there were no visual indicators when hovering over a menu item, aside from the focus border. With this change, we're adding `hover` and `active` styles to the menu items.

fix(ui5-wizard): improve focus and keyboard handling (#9758)

b4f38af

FIXES: #9670 FIXES: #9571

chore(ui5-calendar-legend): fix unstable test (#9784)

974960f

Fixate the date, as some months are not filled correctly with special dates

chore: textarea scrollbar (#9789)

f6eac6b

docs(ui5-calendar): remove public from inner components (#9769)

cd5e113

removing public from documentation of private(internal) components

chore(tests): resize browser on device simulation (#9791)

787bcf1

fix(ui5-color-picker): adjust hue slider update (#9735)

7555361

Fixes: #9693

chore(release): publish v2.2.0 [ci skip]

a6a7a0e

pskelin and others added 10 commits September 4, 2024 18:18

chore: default texts are populated from translations (#9786)

8065ae0

feat(ui5-tabcontainer): implement tabs reordering with the keyboard (#…

972af72

…9585) Co-authored-by: Petar Dimov <[email protected]>

fix(ui5-date-picker): uncomment failing test (#9794)

4869bcd

fixes: #5203

fix(ui5-form): fix layout issues by importing base params in all them…

57f4a27

…es (#9800) The base params used to be included only in the default theme (sap_horizon) and not included in the rest. By adding the params everything looks same in all themes. Fixes: #9788

chore(ui5-text): remove duplicated jsdoc (#9805)

8f85158

chore: enable cypress tests in fiori package (#9793)

130ebd7

fix(ui5-segmented-button): add accessible name in the sample (#9809)

b61f6e1

Fixes: #9011

chore(website): properly resolve path on Windows (#9815)

3f710fb

fix(textarea): Focus Outline Touching Borders in Readonly Textarea

887efd6

Merge branch 'SAP:main' into main

97fc6e6

tw4 force-pushed the main branch 2 times, most recently from 2bc21a4 to 97fc6e6 Compare September 4, 2024 15:20

tw4 closed this Sep 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(textarea): Focus Outline Touching Borders in Readonly Textarea #9759

fix(textarea): Focus Outline Touching Borders in Readonly Textarea #9759

tw4 commented Aug 27, 2024

nnaydenow commented Aug 27, 2024

nnaydenow commented Sep 4, 2024

tw4 commented Sep 4, 2024

cla-assistant bot commented Sep 4, 2024 •

edited

Loading

fix(textarea): Focus Outline Touching Borders in Readonly Textarea #9759

fix(textarea): Focus Outline Touching Borders in Readonly Textarea #9759

Conversation

tw4 commented Aug 27, 2024

nnaydenow commented Aug 27, 2024

nnaydenow commented Sep 4, 2024

tw4 commented Sep 4, 2024

cla-assistant bot commented Sep 4, 2024 • edited Loading

cla-assistant bot commented Sep 4, 2024 •

edited

Loading