-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-link, ui5-switch, ...): add focus support for mobile #9718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are different styles (we are looking at the text underlining) when a Link is in
focused
state and is being hovered upon; - When the Link is focused, the text is always being changed to white, while it should be considering the color (if being overstyled, check the second example);
Before (Correct behaviours)
After
@hinzzx We had a discussion with the Core team and we decided to proceed with the current solution, even if it removes the opportunity to overstyle the link directly when focused. The reasons discussed were that it can always be overstyled by changing the css variable value, which is the most common use case for us, and also is an edge case that will rarely be hit. Based on these two, we decided that this should not be stopper for us to continue with the implementation and review. You can proceed with the review. |
Like #8414,
Link
Switch
,ColorPicker
, andTimeSelectionClocks
elements can now receive focus when using keyboards on mobile devices.Related to: #8322