-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-menu): Enhance keyboard navigation #10243
Merged
Merged
+118
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unazko
reviewed
Nov 25, 2024
unazko
reviewed
Nov 25, 2024
unazko
reviewed
Nov 25, 2024
Todor-ads
changed the title
feat(ui5-menu): endContent is now accessible via keyboard
feat(ui5-menu): Enhance keyboard navigation
Nov 25, 2024
unazko
reviewed
Nov 25, 2024
vladitasev
requested changes
Jan 23, 2025
vladitasev
approved these changes
Jan 24, 2025
alexandar-mitsev
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in popover are ok.
vladitasev
approved these changes
Jan 27, 2025
🎉 This PR is included in version v2.7.0-rc.2 🎉 The release is available on v2.7.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, it will be possible to navigate through the elements added to the endContent using the left and right arrow keys on the keyboard
BGSOFUIBALKAN-8852