Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-menu): Enhance keyboard navigation #10243

Merged
merged 23 commits into from
Jan 27, 2025
Merged

Conversation

Todor-ads
Copy link
Member

@Todor-ads Todor-ads commented Nov 25, 2024

After this change, it will be possible to navigate through the elements added to the endContent using the left and right arrow keys on the keyboard

BGSOFUIBALKAN-8852

packages/main/src/Menu.ts Outdated Show resolved Hide resolved
@Todor-ads Todor-ads changed the title feat(ui5-menu): endContent is now accessible via keyboard feat(ui5-menu): Enhance keyboard navigation Nov 25, 2024
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Show resolved Hide resolved
@unazko unazko self-requested a review December 19, 2024 23:50
packages/main/src/MenuItem.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Show resolved Hide resolved
@Todor-ads Todor-ads requested a review from vladitasev January 23, 2025 11:37
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/Menu.ts Outdated Show resolved Hide resolved
packages/main/src/MenuItem.ts Outdated Show resolved Hide resolved
@Todor-ads Todor-ads requested a review from vladitasev January 24, 2025 07:06
packages/main/src/Menu.ts Show resolved Hide resolved
Copy link
Contributor

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in popover are ok.

@vladitasev vladitasev merged commit 34d604d into main Jan 27, 2025
10 checks passed
@vladitasev vladitasev deleted the menu-content-navigation branch January 27, 2025 11:32
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.7.0-rc.2 🎉

The release is available on v2.7.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants