fix: Prevent 3rd party script to load ssr #19443
Open
+35
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FollowTheFlo
commented
Oct 24, 2024
| @@ -23,14 +24,26 @@ import { OpfCtaScriptsService } from '../opf-cta-scripts/opf-cta-scripts.service | |||
| export class OpfCtaElementComponent implements AfterViewInit { | |||
| protected sanitizer = inject(DomSanitizer); | |||
| protected opfCtaScriptsService = inject(OpfCtaScriptsService); | |||
| loader = true; | |||
FollowTheFlo
commented
Oct 24, 2024
| } | ||
|
|
||
| // Removing script tags on FE until BE fix: CXSPA-8572 | ||
| protected removeScriptTags(html: string) { |
There was a problem hiding this comment.
This function can only be used in CSR as using DOMParser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent 3rd party JS to load in ssr
SSR only load 3rd party html as sanitized html thus cleaning any script and non-standard html tags. it also keeps the inline css.