Add an option to open source FE writer `generate` to enable writing annotations. #2849

kjose90 · 2025-01-30T10:14:38Z

#2773

Added option addAnnotations to FioriElementsApp interface.
Added logic to write annotations if addAnnotations is enabled and template type is LROP/ Worklist and service is OData version 4 or if template type is FEOP.
Unit tests

…into moveCapUpdates

… into updateCapService

devinea

Code changes are clean and covered by tests.
Thanks for the updates.
Changeset ✅

packages/fiori-elements-writer/src/data/writeAnnotations.ts

packages/fiori-elements-writer/src/index.ts

packages/fiori-elements-writer/src/translations/fiori-elements-writer.i18n.json

devinea

Re-approving.

packages/fiori-elements-writer/src/writeAnnotations.ts

packages/fiori-elements-writer/src/index.ts

IainSAP

Thx @kjose90

Changes are clear
Tests updated to cover

devinea

re-approve

sonarqubecloud · 2025-02-04T14:56:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kjose90 and others added 30 commits January 16, 2025 15:47

add enable npm workspaces to appOptions

b9dfe11

removing unecessary console logs

3dd9c4c

removing debugger

d246d0e

Merge branch 'main' into moveCapUpdates

560cb17

lint issues

3f89f43

Linting auto fix commit

d763ff1

unit tests

901a6e5

Merge branch 'moveCapUpdates' of https://github.com/SAP/open-ux-tools …

82bd7e2

…into moveCapUpdates

Linting auto fix commit

3d88289

Merge branch 'main' into moveCapUpdates

a120f48

remove unused reference to package type

87020f2

sonar qube fix

811810b

add documentation to enable npm workspaces type

dea250e

add enableNPMWorkspaces doc to f-f-w

cee24bb

add comment

b2fed1e

Move and types from to

e1851b8

remve old changeset

9a5d436

merge main and fix conflicts

20a39b7

Linting auto fix commit

3490ac7

Merge branch 'main' into updateCapService

da1f726

enable npm workspace comment

ca59e47

js doc fix

b01a596

Merge branch 'updateCapService' of https://github.com/SAP/open-ux-tools…

e4546f7

… into updateCapService

Linting auto fix commit

110da8c

js doc fix

1bb7159

js doc fix

b01bef7

Linting auto fix commit

200aed4

Merge branch 'main' into updateCapService

4596f1f

Merge branch 'main' into updateCapService

b33329b

remove enable npm workspace options from ff and fe appOptions

6e359be

kjose90 added 2 commits January 31, 2025 12:30

fix test for write annotations

2bfb2c8

sonar issues

de66d3c

devinea previously approved these changes Jan 31, 2025

View reviewed changes

IainSAP assigned kjose90 Jan 31, 2025

IainSAP reviewed Jan 31, 2025

View reviewed changes

packages/fiori-elements-writer/src/data/writeAnnotations.ts Outdated Show resolved Hide resolved

IainSAP reviewed Jan 31, 2025

View reviewed changes

packages/fiori-elements-writer/src/data/writeAnnotations.ts Outdated Show resolved Hide resolved

IainSAP reviewed Jan 31, 2025

View reviewed changes

packages/fiori-elements-writer/src/index.ts Outdated Show resolved Hide resolved

IainSAP reviewed Jan 31, 2025

View reviewed changes

packages/fiori-elements-writer/src/translations/fiori-elements-writer.i18n.json Outdated Show resolved Hide resolved

move writeAnnotations and improvise

c3e53c6

kjose90 dismissed devinea’s stale review via c3e53c6 January 31, 2025 17:36

add annotationGenerationSupport to TemplateAttributes

0858cdc

kjose90 requested review from IainSAP and devinea February 4, 2025 09:31

devinea previously approved these changes Feb 4, 2025

View reviewed changes

IainSAP reviewed Feb 4, 2025

View reviewed changes

packages/fiori-elements-writer/src/writeAnnotations.ts Outdated Show resolved Hide resolved

improvise write annotations

f56e617

kjose90 dismissed devinea’s stale review via f56e617 February 4, 2025 12:52

kjose90 added 2 commits February 4, 2025 12:55

improvise write annotations

d4ab118

fix sonar issue

d425b93

IainSAP reviewed Feb 4, 2025

View reviewed changes

packages/fiori-elements-writer/src/index.ts Outdated Show resolved Hide resolved

move log warn inside writeAnnotations

dd4003a

IainSAP approved these changes Feb 4, 2025

View reviewed changes

Merge branch 'main' into moveWriteAnnotationsLogic

ed93d85

devinea approved these changes Feb 4, 2025

View reviewed changes

Merge branch 'main' into moveWriteAnnotationsLogic

73577cf

kjose90 merged commit c4d9d0d into main Feb 4, 2025
16 checks passed

kjose90 deleted the moveWriteAnnotationsLogic branch February 4, 2025 14:56

This was referenced Feb 6, 2025

Add error handling write annotation #2886

Merged

BUG - Annotations Not Generated in CAP Project When addAnnotation is Enabled with In-Memory FS #2890

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option to open source FE writer `generate` to enable writing annotations. #2849

Add an option to open source FE writer `generate` to enable writing annotations. #2849

kjose90 commented Jan 30, 2025

devinea left a comment

devinea left a comment

IainSAP left a comment

devinea left a comment

sonarqubecloud bot commented Feb 4, 2025

Add an option to open source FE writer generate to enable writing annotations. #2849

Add an option to open source FE writer generate to enable writing annotations. #2849

Conversation

kjose90 commented Jan 30, 2025

devinea left a comment

Choose a reason for hiding this comment

devinea left a comment

Choose a reason for hiding this comment

IainSAP left a comment

Choose a reason for hiding this comment

devinea left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 4, 2025

Quality Gate passed

Add an option to open source FE writer `generate` to enable writing annotations. #2849

Add an option to open source FE writer `generate` to enable writing annotations. #2849