Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate Common.SecondaryKey #343

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Undeprecate Common.SecondaryKey #343

merged 5 commits into from
Oct 7, 2024

Conversation

HeikoTheissen
Copy link
Contributor

No description provided.

Copy link
Member

@BerSie BerSie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and we may set it to experimental ...

@@ -218,15 +218,12 @@
</Term>

<Term Name="SecondaryKey" AppliesTo="EntityType" Type="Collection(Edm.PropertyPath)" Nullable="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of our colleagues mentioned that it would make sense in course of this de-deprecation to call the term SecondaryKeys as it's a collection (analogous to AlternateKeys from the Core vocabulary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a single secondary key with one or more key properties - we do have lots of multi-part keys at SAP.

Multiple secondary keys are differentiated via qualifiers.

<Annotation Term="Core.LongDescription">
<String>Multiple secondary keys are possible using different qualifiers.
Unlike [`Core.AlternateKeys`](https://github.com/oasis-tcs/odata-vocabularies/blob/main/vocabularies/Org.OData.Core.V1.md#AlternateKeys),
secondary keys cannot be used to address an entity in a resource path.</String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase it a bit weaker ... in a sense that this addressing is not required (but I wouldn't mind if we go with your proposal)

@@ -218,15 +218,12 @@
</Term>

<Term Name="SecondaryKey" AppliesTo="EntityType" Type="Collection(Edm.PropertyPath)" Nullable="false">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a single secondary key with one or more key properties - we do have lots of multi-part keys at SAP.

Multiple secondary keys are differentiated via qualifiers.

vocabularies/Common.xml Outdated Show resolved Hide resolved
@ralfhandl ralfhandl marked this pull request as ready for review September 25, 2024 07:57
ralfhandl
ralfhandl previously approved these changes Sep 25, 2024
@HeikoTheissen HeikoTheissen merged commit daf2444 into main Oct 7, 2024
3 checks passed
@HeikoTheissen HeikoTheissen deleted the Common.SecondaryKey branch October 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants