Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing type declaration on luigi element #4129

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adds missing type declaration on luigi element #4129

wants to merge 6 commits into from
+272 −12

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds missing type declaration on luigi element
  • adds related e2e test cases

Related issue(s)

Resolves #4125

@walmazacn walmazacn linked an issue Jan 27, 2025 that may be closed by this pull request
Missing type declaration on luigi-element #4125
Open
@JohannesDoberer JohannesDoberer self-assigned this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@JohannesDoberer JohannesDoberer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing type declaration on luigi-element
2 participants
@walmazacn @JohannesDoberer