feat(sonar): respect existing SONAR_SCANNER_OPTS definition

[inf2381]

Description

Currently, it is not possible to set the environment variable SONAR_SCANNER_OPTS outside of piper when running sonarExecuteScan because it will be overwritten by the keystore config. This PR adds the functionality to append the keystore config to the existing scanner opts if they are present.

Checklist

• Tests
• Documentation
• Inner source library needs updating

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[CCFenner]

👍 thanks for the fix

[CCFenner]

Please have a look at the failing tests:

--- FAIL: TestSonarLoadCertificates (0.00s)
    --- FAIL: TestSonarLoadCertificates/use_local_trust_store (0.00s)
        sonarExecuteScan_test.go:464: 
            	Error Trace:	/home/runner/work/jenkins-library/jenkins-library/cmd/sonarExecuteScan_test.go:464
            	Error:      	[]string{"SONAR_SCANNER_OPTS=-Xmx42m -Djavax.net.ssl.trustStore=/home/runner/work/jenkins-library/jenkins-library/cmd/.certificates/cacerts -Djavax.net.ssl.trustStorePassword=changeit"} does not contain "SONAR_SCANNER_OPTS=-Djavax.net.ssl.trustStore=/home/runner/work/jenkins-library/jenkins-library/cmd/.certificates/cacerts -Djavax.net.ssl.trustStorePassword=changeit"
            	Test:       	TestSonarLoadCertificates/use_local_trust_store
    --- FAIL: TestSonarLoadCertificates/use_local_trust_store_with_downloaded_certificates (0.00s)
        sonarExecuteScan_test.go:483: 
            	Error Trace:	/home/runner/work/jenkins-library/jenkins-library/cmd/sonarExecuteScan_test.go:483
            	Error:      	[]string{"SONAR_SCANNER_OPTS=-Xmx42m -Djavax.net.ssl.trustStore=/home/runner/work/jenkins-library/jenkins-library/cmd/.certificates/cacerts -Djavax.net.ssl.trustStorePassword=changeit"} does not contain "SONAR_SCANNER_OPTS=-Djavax.net.ssl.trustStore=/home/runner/work/jenkins-library/jenkins-library/cmd/.certificates/cacerts -Djavax.net.ssl.trustStorePassword=changeit"
            	Test:       	TestSonarLoadCertificates/use_local_trust_store_with_downloaded_certificates