Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Enable custom version release #252

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Oct 21, 2024

Context

Allows providing a custom version while releasing a new version of the library.

Feature Scope

  • Enhance GH action, to allow providing a custom version
  • Modify the underlying python scripts to consume the custom version specified

Definition of Done

  • Feature scope is implemented
  • Feature scope is tested
  • [ ] Feature scope is documented
  • [ ] Release notes are created

@KavithaSiva KavithaSiva marked this pull request as draft October 21, 2024 14:13
@KavithaSiva KavithaSiva marked this pull request as ready for review October 23, 2024 15:33
@@ -57,7 +58,7 @@ def bump_version(
)

updated_versions: dict[str, str] = self._bump_versions(
current_versions, bump_type
current_versions, bump_type, custom_version
Copy link
Contributor

@newtork newtork Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Minor)

Not ideal argument namings with combined current_versions: dict[str,str] and current_version: str, requires the reader/maintainer to look it up first.

Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KavithaSiva KavithaSiva merged commit 96cb115 into main Oct 25, 2024
6 checks passed
@KavithaSiva KavithaSiva deleted the feat/enable-custom-version-release branch October 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants