[READY] v2.x - Small cleanups #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
commented
Jan 11, 2025
| @@ -157,7 +159,7 @@ def inflate(deflated) | |||
| # @return [String] The deflated string | |||
| # | |||
| def deflate(inflated) | |||
| Zlib::Deflate.deflate(inflated, 9)[2..-5] | |||
| Zlib::Deflate.deflate(inflated, Zlib::BEST_COMPRESSION)[2..-5] | |||
There was a problem hiding this comment.
Zlib::BEST_COMPRESSION == 9
johnnyshields
commented
Jan 11, 2025
| def fingerprint(certificate, fingerprint_algorithm = RubySaml::XML::Document::SHA256) | ||
| @fingerprint ||= begin | ||
| return unless certificate | ||
| def fingerprint(certificate, fingerprint_algorithm = RubySaml::XML::Crypto::SHA256) |
There was a problem hiding this comment.
This method takes arguments so it can't be memoized (can't do @fingerprint ||= ... here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly syntax cleanup, but there is one bugfix re: IdpMetadataParser--currently the
#fingerprintmethod memoizes its result, and it should not b/c it takes arguments.