[WIP] v3.x - Replace REXML with Nokogiri #736
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729
Fixes #707
Currently Ruby Saml uses a mix of REXML and Nokogiri. This is not ideal. We should use Nokogiri everywhere, because it can do everything REXML can do.
In addition, note:
REXML::Security.entity_expansion_limit = 0
which affects it for all gems in the project.This refactor will probably get rid of
RubySaml::XML::Document
, etc.. Currently these are subclasses ofREXML::Document
. What we should do instead is make them procedural classes likeDocumentSigner
andSignedDocumentValidator
. Hence I'm thinking it will be v3.0