Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] v3.x - Replace REXML with Nokogiri #736

Open
wants to merge 2 commits into
base: v2.x
Choose a base branch
from

Conversation

johnnyshields
Copy link
Collaborator

@johnnyshields johnnyshields commented Jan 11, 2025

Fixes #729
Fixes #707

Currently Ruby Saml uses a mix of REXML and Nokogiri. This is not ideal. We should use Nokogiri everywhere, because it can do everything REXML can do.

In addition, note:

  • Ruby Saml is currently setting REXML::Security.entity_expansion_limit = 0 which affects it for all gems in the project.
  • The above is not thread-safe, while Nokogiri is thread-safe by design.
  • REXML does not use Semver, and exposes users to sudden breakage.

This refactor will probably get rid of RubySaml::XML::Document, etc.. Currently these are subclasses of REXML::Document. What we should do instead is make them procedural classes like DocumentSigner and SignedDocumentValidator. Hence I'm thinking it will be v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant