Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support frozen strings with REXML #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support frozen strings with REXML #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/authrequest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def create_params(settings, params={})
request_doc = create_authentication_xml_doc(settings)
request_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values

request = ""
request = +""
request_doc.write(request)

Logging.debug "Created AuthnRequest: #{request}"
Expand Down
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/logoutrequest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def create_params(settings, params={})
request_doc = create_logout_request_xml_doc(settings)
request_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values

request = ""
request = +""
request_doc.write(request)

Logging.debug "Created SLO Logout Request: #{request}"
Expand Down
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/metadata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def embed_signature(meta_doc, settings)
end

def output_xml(meta_doc, pretty_print)
ret = ''
ret = +''

# pretty print the XML so IdP administrators can easily see what the SP supports
if pretty_print
Expand Down
2 changes: 1 addition & 1 deletion lib/onelogin/ruby-saml/slo_logoutresponse.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def create_params(settings, request_id = nil, logout_message = nil, params = {},
response_doc = create_logout_response_xml_doc(settings, request_id, logout_message, logout_status_code)
response_doc.context[:attribute_quote] = :quote if settings.double_quote_xml_attribute_values

response = ""
response = +""
response_doc.write(response)

Logging.debug "Created SLO Logout Response: #{response}"
Expand Down
6 changes: 3 additions & 3 deletions lib/onelogin/ruby-saml/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Utils
(\d+)W # 8: Weeks
)
$)x.freeze
UUID_PREFIX = '_'
UUID_PREFIX = +'_'

# Checks if the x509 cert provided is expired.
#
Expand Down Expand Up @@ -262,11 +262,11 @@ def self.status_error_msg(error_msg, raw_status_code = nil, status_message = nil
else
printable_code = raw_status_code.split(':').last
end
error_msg << ', was ' + printable_code
error_msg += ', was ' + printable_code
end

unless status_message.nil?
error_msg << ' -> ' + status_message
error_msg += ' -> ' + status_message
end

error_msg
Expand Down
Loading