last refactor PR of 2018 🎉🎉🎉 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More appropriate name.
|
Ah interesting, it appears I've broken something. Jenkins ftw |
adrianherrera
force-pushed
the
improvement/refactoring
branch
from
a5b232d
to
22d02c0
Compare
vitalych
reviewed
Dec 31, 2018
vitalych
approved these changes
Dec 31, 2018
adrianherrera
force-pushed
the
improvement/refactoring
branch
4 times, most recently
from
99dfefc
to
e248060
Compare
Added Target class to encapsulate an S2E analysis target. This makes testing and custom projects much easier to handle
Name and module are more suitable
Useful for custom projects
library.lua is not a Jinja template and there is nothing to render. Moved it to dat and added a helper method to copy it to a given project directory (useful for custom projects).
This makes it harder to set logging programmatically. Setting the log level via the S2E config file was largely redundant due to the S2EENV_LOG_LEVEL environment variable.
As per PEP 3119.
Useful for custom projects outside of the s2e-env module.
adrianherrera
force-pushed
the
improvement/refactoring
branch
from
e248060
to
66a4758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to support S2E/guest-images#19 and trailofbits/deepstate#155
Summary:
Targetclass for abstracting over analysis targets (+ tests)