Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Pull Request #25

Merged
merged 82 commits into from
Dec 14, 2023
Merged

Final Pull Request #25

merged 82 commits into from
Dec 14, 2023

Conversation

IsmaelMastronardi
Copy link
Collaborator

Appoint Wheels

This project of @Rysth was made in collaboration with @Rebelzob , @IsmaelMastronardi and @SnakyMz
The Project has two repositories:

Things we have done:

Backend

  • Setup the database as per the ERD diagram
  • Implement API only routes to handle JSON requests
  • Added Documentation of the API using Rswag

Frontend

  • Added Login page and SignUp pages for user authentication
  • Added protected routes to block non-user visits
  • Added HomePage to display all available Cars for Rental
  • Added Navigation bar for good UX
  • Added CarDetails page to display information and option to rent selected Car
  • Added NewCar page to add new Cars for Rental
  • Added DeleteCar page to delete Cars from Rental
  • Added Rentals page to display and delete rentals made by the specific user
  • Added NewRental page for the user to create a new rental

Additional features - Required only for teams with 5 members (optional for others)

  • Installed Devise, JWT and Cancancan to implement authentication and authorization in the backend
  • Implemented authorization for the NewCar and DeleteCar links to be only accessible by users who are admins

Copy link

gitguardian bot commented Dec 14, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8943089 Generic High Entropy Secret 284566b config/initializers/devise.rb View secret
8943089 Generic High Entropy Secret 22edfa3 config/initializers/devise.rb View secret
8943089 Generic High Entropy Secret 7e2cc17 config/initializers/devise.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Rebelzob Rebelzob self-requested a review December 14, 2023 19:09
Copy link
Collaborator

@Rebelzob Rebelzob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ All Linters passed

  • The project was already reviewed by an external code reviewer and its ready to merge

Good job team!

@Rebelzob Rebelzob merged commit 862ecff into main Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants