Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add authenticate user #24

Closed
wants to merge 32 commits into from

Conversation

IsmaelMastronardi
Copy link
Collaborator

@IsmaelMastronardi IsmaelMastronardi commented Dec 11, 2023

Authentication and Authorization

Authentication:

  • Added authenticate_user to application_controller.rb
  • Added before_action :authenticate_user to cars_controller and rentals_controller.

Authorization:

  • Added cancancan.
  • Added ability file.
  • The user can read all and manage rental
  • The admin can manage all.
  • Added "role" to the user (created migration, updated schema, updated seed, updated serialized)
  • Added admin? method to user model.

Miscellaneous:

  • Routes.rb now has only necessary routes.

Copy link

gitguardian bot commented Dec 11, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
9037630 Generic High Entropy Secret ae43793 app/controllers/application_controller.rb View secret
9037630 Generic High Entropy Secret 4a48a5d app/controllers/application_controller.rb View secret
9037630 Generic High Entropy Secret 9463225 app/controllers/application_controller.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@IsmaelMastronardi IsmaelMastronardi deleted the feature/add_authenticate_user branch December 12, 2023 15:49
@IsmaelMastronardi IsmaelMastronardi restored the feature/add_authenticate_user branch December 12, 2023 15:49
@IsmaelMastronardi IsmaelMastronardi deleted the feature/add_authenticate_user branch December 12, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant