release: 0.40.12

RyotaUshio · Oct 22, 2024 · d451527 · d451527
1 parent 9b07618
commit d451527
Show file tree

Hide file tree

Showing 61 changed files with 952 additions and 632 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -22,6 +22,12 @@
       "no-prototype-builtins": "off",
       "@typescript-eslint/no-empty-function": "off",
       "@typescript-eslint/no-this-alias": "off",
-      "@typescript-eslint/no-inferrable-types": ["error", { "ignoreParameters": true, "ignoreProperties": true }]
+      "@typescript-eslint/no-inferrable-types": ["error", { "ignoreParameters": true, "ignoreProperties": true }],
+      "semi": ["error", "always"],
+      "semi-spacing": ["error", {"after": true, "before": false}],
+      "semi-style": ["error", "last"],
+      "no-extra-semi": "error",
+      "no-unexpected-multiline": "error",
+      "no-unreachable": "error"
     } 
   }
diff --git a/manifest-beta.json b/manifest-beta.json
@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.40.11",
+    "version": "0.40.12",
     "minAppVersion": "1.5.8",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.40.11",
+    "version": "0.40.12",
     "minAppVersion": "1.5.8",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "obsidian-pdf-plus",
-    "version": "0.40.11",
+    "version": "0.40.12",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "scripts": {
         "dev": "node esbuild.config.mjs",

diff --git a/src/auto-copy.ts b/src/auto-copy.ts
@@ -33,7 +33,7 @@ export class AutoCopyMode extends PDFPlusComponent {
                                 this.plugin.openSettingTab().scrollToHeading('auto-copy');
                             });
                     });
-                    menu.onHide(() => { menuShown = false });
+                    menu.onHide(() => { menuShown = false; });
                     menu.showAtMouseEvent(evt);
                     menuShown = true;
                 });

diff --git a/src/backlink-visualizer.ts b/src/backlink-visualizer.ts
@@ -162,7 +162,7 @@ export class BacklinkDomManager extends PDFPlusComponent {
                                 backlinkItemEl.removeClass('hovered-backlink');
                                 el.removeEventListener('mouseout', listener);
                             }
-                        }
+                        };
                         el.addEventListener('mouseout', listener);
                     }
                 });

diff --git a/src/bib.ts b/src/bib.ts
@@ -91,7 +91,7 @@ export class BibliographyManager extends PDFPlusComponent {
             hoverPopover.addChild(
                 new BibliographyDom(this, destId, bibContainerEl)
             );
-        }
+        };
 
         if (this.plugin.requireModKeyForLinkHover(BibliographyManager.HOVER_LINK_SOURCE_ID)) {
             onModKeyPress(event, targetEl, spawnBibPopover);

diff --git a/src/color-palette.ts b/src/color-palette.ts
@@ -234,7 +234,7 @@ export class ColorPalette extends PDFPlusComponent {
     addCopyActionDropdown(paletteEl: HTMLElement) {
         let tooltip = 'Link copy format';
         if (!this.plugin.settings.colorPaletteInToolbar) {
-            tooltip = `${this.plugin.manifest.name}: link copy options (trigger via hotkeys)`
+            tooltip = `${this.plugin.manifest.name}: link copy options (trigger via hotkeys)`;
         }
 
         const buttonEl = this.addDropdown(
@@ -427,7 +427,7 @@ export class ColorPalette extends PDFPlusComponent {
     addCropButton(paletteEl: HTMLElement) {
         this.cropButtonEl = paletteEl.createDiv('clickable-icon pdf-plus-rect-select', (el) => {
             setIcon(el, 'lucide-box-select');
-            setTooltip(el, 'Copy embed link to rectangular selection')
+            setTooltip(el, 'Copy embed link to rectangular selection');
 
             el.addEventListener('click', () => {
                 this.startRectangularSelection(false);
@@ -470,7 +470,7 @@ export class ColorPalette extends PDFPlusComponent {
             // Determine the target page based on the event target
             if (!(isTargetHTMLElement(evt, evt.target))) return;
 
-            const pageEl = evt.target.closest<HTMLElement>('.pdf-viewer div.page[data-page-number]')
+            const pageEl = evt.target.closest<HTMLElement>('.pdf-viewer div.page[data-page-number]');
             if (!pageEl) return;
 
             const pageNumber = pageEl.dataset.pageNumber;

diff --git a/src/context-menu.ts b/src/context-menu.ts
@@ -39,7 +39,7 @@ export const onContextMenu = async (plugin: PDFPlus, child: PDFViewerChild, evt:
     if (!evt.defaultPrevented) {
         await showContextMenu(plugin, child, evt);
     }
-}
+};
 
 export async function showContextMenu(plugin: PDFPlus, child: PDFViewerChild, evt: MouseEvent) {
     const menu = await PDFPlusContextMenu.fromMouseEvent(plugin, child, evt);
@@ -65,7 +65,7 @@ export async function showContextMenuAtSelection(plugin: PDFPlus, child: PDFView
     const { x, y } = range.getBoundingClientRect();
 
     const menu = new PDFPlusContextMenu(plugin, child);
-    await menu.addItems()
+    await menu.addItems();
     child.clearEphemeralUI();
     plugin.shownMenus.forEach((menu) => menu.hide());
     menu.showAtPosition({ x, y }, doc);
@@ -94,7 +94,7 @@ export const onThumbnailContextMenu = (plugin: PDFPlus, child: PDFViewerChild, e
                         (evt.view ?? activeWindow).navigator.clipboard.writeText(link);
                         const file = child.file;
                         if (file) plugin.lastCopiedDestInfo = { file, destArray: [pageNumber - 1, 'XYZ', null, null, null] };
-                    })
+                    });
             });
 
         if (lib.isEditable(child)) {
@@ -108,7 +108,7 @@ export const onThumbnailContextMenu = (plugin: PDFPlus, child: PDFViewerChild, e
                             return;
                         }
                         lib.commands._insertPage(file, pageNumber, pageNumber);
-                    })
+                    });
             })
                 .addItem((item) => {
                     item.setTitle('Insert page after this page')
@@ -120,7 +120,7 @@ export const onThumbnailContextMenu = (plugin: PDFPlus, child: PDFViewerChild, e
                                 return;
                             }
                             lib.commands._insertPage(file, pageNumber + 1, pageNumber);
-                        })
+                        });
                 })
                 .addItem((item) => {
                     item.setTitle('Delete page')
@@ -132,7 +132,7 @@ export const onThumbnailContextMenu = (plugin: PDFPlus, child: PDFViewerChild, e
                                 return;
                             }
                             lib.commands._deletePage(file, pageNumber);
-                        })
+                        });
                 })
                 .addItem((item) => {
                     item.setTitle('Extract page to new file')
@@ -166,12 +166,12 @@ export const onThumbnailContextMenu = (plugin: PDFPlus, child: PDFViewerChild, e
                         .onClick(() => {
                             plugin.openSettingTab().scrollToHeading('thumbnail');
                         });
-                })
+                });
         }
 
         menu.showAtMouseEvent(evt);
     }
-}
+};
 
 // TODO: split into smaller methods
 export const onOutlineItemContextMenu = (plugin: PDFPlus, child: PDFViewerChild, file: TFile, item: PDFOutlineTreeNode, evt: MouseEvent) => {
@@ -201,7 +201,7 @@ export const onOutlineItemContextMenu = (plugin: PDFPlus, child: PDFViewerChild,
                         const destArray = lib.normalizePDFJsDestArray(dest, pageNumber);
                         plugin.lastCopiedDestInfo = { file, destArray };
                     }
-                })
+                });
         });
 
     if (lib.isEditable(child)) {
@@ -375,7 +375,7 @@ export const onOutlineItemContextMenu = (plugin: PDFPlus, child: PDFViewerChild,
     }
 
     menu.showAtMouseEvent(evt);
-}
+};
 
 
 export const onOutlineContextMenu = (plugin: PDFPlus, child: PDFViewerChild, file: TFile, evt: MouseEvent) => {
@@ -410,7 +410,7 @@ export const onOutlineContextMenu = (plugin: PDFPlus, child: PDFViewerChild, fil
             })
             .showAtMouseEvent(evt);
     }
-}
+};
 
 
 export class PDFPlusMenu extends Menu {
@@ -435,7 +435,7 @@ export class PDFPlusMenu extends Menu {
 }
 
 export class PDFPlusContextMenu extends PDFPlusMenu {
-    child: PDFViewerChild
+    child: PDFViewerChild;
 
     constructor(plugin: PDFPlus, child: PDFViewerChild) {
         super(plugin);
@@ -474,7 +474,7 @@ export class PDFPlusContextMenu extends PDFPlusMenu {
 
         const isVisible = (id: string) => {
             return this.settings.contextMenuConfig.find((section) => section.id === id)?.visible;
-        }
+        };
 
         // If macOS, add "look up selection" action
         if (Platform.isMacOS && Platform.isDesktopApp && this.win.electron && selectedText && isVisible('action')) {
@@ -660,7 +660,7 @@ export class PDFPlusContextMenu extends PDFPlusMenu {
                                 .onClick(() => {
                                     navigator.clipboard.writeText(url);
                                 });
-                        })
+                        });
                     }
                 }
             }
@@ -722,7 +722,7 @@ export class PDFPlusContextMenu extends PDFPlusMenu {
                         // How does the electron version differ?
                         navigator.clipboard.writeText(annotatedText!);
                     });
-            })
+            });
         }
 
         if (selectedText && selection && isVisible('search')) {
@@ -887,13 +887,13 @@ export class PDFPlusProductMenuComponent extends PDFPlusComponent {
 
                 if (this.section && menu === this.rootMenu) item.setSection(this.section);
 
-                this.itemToColorName.set(item, i >= 0 ? colorNames[i] : null)
+                this.itemToColorName.set(item, i >= 0 ? colorNames[i] : null);
 
                 const hex = this.settings.colors[i >= 0 ? colorNames[i] : 'transparent'];
                 item.dom.addClass('pdf-plus-color-menu-item');
                 item.titleEl.before(createDiv('pdf-plus-color-indicator', (el) => {
                     el.setCssStyles({ backgroundColor: hex });
-                }))
+                }));
             });
         }
 

diff --git a/src/dom-manager.ts b/src/dom-manager.ts
@@ -236,7 +236,7 @@ class PDFPlusCalloutRenderer extends MarkdownRenderChild {
 	onload() {
 		const metadata = this.containerEl.dataset.calloutMetadata;
 		if (metadata) {
-			const rgb = metadata.split(',').map((val) => parseInt(val))
+			const rgb = metadata.split(',').map((val) => parseInt(val));
 			const isRgb = rgb.length === 3 && rgb.every((val) => 0 <= val && val <= 255);
 
 			if (isRgb) {

diff --git a/src/drag.ts b/src/drag.ts
@@ -34,7 +34,7 @@ export const registerOutlineDrag = async (plugin: PDFPlus, pdfOutlineViewer: PDF
                     title,
                     getText: textGenerator,
                     item
-                }
+                };
             });
 
             app.dragManager.handleDrop(item.selfEl, (evt, draggable, dragging) => {
@@ -74,10 +74,10 @@ export const registerOutlineDrag = async (plugin: PDFPlus, pdfOutlineViewer: PDF
                         dropEffect: 'move',
                         hoverEl: item.el,
                         hoverClass: 'is-being-dragged-over',
-                    }
+                    };
                 }
             }, false);
-        })())
+        })());
     }
 
     await Promise.all(promises);
@@ -116,10 +116,10 @@ export const registerOutlineDrag = async (plugin: PDFPlus, pdfOutlineViewer: PDF
                 dropEffect: 'move',
                 hoverEl: pdfOutlineViewer.childrenEl,
                 hoverClass: 'is-being-dragged-over',
-            }
+            };
         }
     }, false);
-}
+};
 
 export const registerThumbnailDrag = (plugin: PDFPlus, child: PDFViewerChild, file: TFile) => {
     const { app, lib } = plugin;
@@ -150,11 +150,11 @@ export const registerThumbnailDrag = (plugin: PDFPlus, child: PDFViewerChild, fi
                             file, pageNumber, `#page=${pageNumber}`, '', '', sourcePath
                         );
                     }
-                }
+                };
             });
 
         });
-}
+};
 
 export const registerAnnotationPopupDrag = (plugin: PDFPlus, popupEl: HTMLElement, child: PDFViewerChild, file: TFile, page: number, id: string) => {
     const { app, lib } = plugin;
@@ -177,7 +177,7 @@ export const registerAnnotationPopupDrag = (plugin: PDFPlus, popupEl: HTMLElemen
                     getText: (sourcePath: string) => {
                         return lib.copyLink.getTextToCopy(child, template, undefined, file, page, `#page=${page}&annotation=${id}`, text ?? '', '', sourcePath);
                     }
-                }
+                };
             });
         });
-}
+};