Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change deployment target to iOS 11 #49

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

nitikorndev
Copy link
Contributor

to solve the issue: #47

@DavidFerreria
Copy link

Waiting for approbation ...

@santieduardo
Copy link

Waiting

@santieduardo
Copy link

@bobgodwinx could you check this PR, please? :)

@av0c0der
Copy link

It is not how the issue should be fixed. Some apps still support iOS 9/10. #47 could be fixed just by limiting the property to iOS 11.

@grangej
Copy link

grangej commented Sep 14, 2021

This is completely broken without this change, its now Sept and Xcode 13 will be released any day.

@Beniryu
Copy link

Beniryu commented Sep 29, 2021

@newoo
@bobgodwinx
Hey guys, sorry I'm pinging those who seem to be the one doing the merges.
Can you take care of it please? This is a critical issue.

@santieduardo
Copy link

@Beniryu
I really gave up waiting for them!
Use this in your podfile:
pod 'RxCoreLocation', :git => 'https://github.com/nitikorndev/RxCoreLocation.git', :branch => 'nitikorndev-patch-1'

Basically it is using the @nitikorndev's pull request for this moment.

@bobgodwinx bobgodwinx merged commit 8c4b301 into RxSwiftCommunity:master Oct 1, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @nitikorndev! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@bobgodwinx
Copy link
Member

It is not how the issue should be fixed. Some apps still support iOS 9/10. #47 could be fixed just by limiting the property to iOS 11.

Deprecating iOS 9/10 support. It's been fun but want to focus on mainly the last 3 versions which will be 12, 13, 14 in the near future.

@bobgodwinx
Copy link
Member

Will create a new pod once Xcode 13 has a GM

@Beniryu
Copy link

Beniryu commented Oct 1, 2021

@Beniryu I really gave up waiting for them! Use this in your podfile: pod 'RxCoreLocation', :git => 'https://github.com/nitikorndev/RxCoreLocation.git', :branch => 'nitikorndev-patch-1'

Basically it is using the @nitikorndev's pull request for this moment.

Thanks @santieduardo , I did so and it worked

@bobgodwinx Thanks, I'll update to the latest version then

@santieduardo
Copy link

@bobgodwinx Did not you create the new release and tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants