Add support for BIP340 signtures where the messages are not exactly 32 bytes #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Apr 15, 2024
k256/src/schnorr/signing.rs
Outdated
| @@ -78,7 +78,7 @@ impl SigningKey { | |||
| /// The preferred interfaces are the [`Signer`] or [`RandomizedSigner`] traits. | |||
| pub fn sign_prehash_with_aux_rand( | |||
There was a problem hiding this comment.
Perhaps this method should be renamed to reflect the input is no longer necessarily a prehash?
Something like sign_raw perhaps?
There was a problem hiding this comment.
Yeah makes sense, I renamed to sign_raw. I didn't know if you wanted to keep any compatability forwarding (eg a #[deprecated] sign_prehash_with_aux_rand that forwards to sign_raw), so I left it out for now.
There was a problem hiding this comment.
That's fine. We can make a note in the changelog.
tarcieri
reviewed
Apr 15, 2024
tarcieri
approved these changes
Apr 24, 2024
altkdf
pushed a commit
to altkdf/elliptic-curves
that referenced
this pull request
Jun 5, 2024
This was an extension to BIP340 that was introduced in 2022. The official BIP340 test vectors do contain data for this case (tests 15-18) which are included here. Fixes RustCrypto#1040
randombit
added a commit
to randombit/elliptic-curves
that referenced
this pull request
Aug 29, 2024
This is a backport of RustCrypto#1041 onto the 0.13 branch, with some small changes to accomodate SemVer. Fixes RustCrypto#1040
tarcieri
pushed a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an extension to BIP340 that was introduced in 2022. The official BIP340 test vectors do contain data for this case (tests 15-18) which are included here.
Fixes #1040