Fix infinite loop on broken ALSA pipes #934
Open
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ALSA interface ends up in an unrecoverable error state (e.g. device disconnected), the thread that runs
input_stream_worker
(oroutput_stream_worker
depending on the type of stream) goes into an infinite loop due to the polling always returning an error.This infinite loop causes calls to
drop(stream)
to hang indefinitely as the Drop implementation tries to join the polling thread.Proposed solution
By adding a flag that's raised when a
Stream
is dropped, we can add an early exit condition topoll_descriptors_and_prepare_buffer
that forces a return value ofPollDescriptorsFlow::Return
.Testing
I successfully tested the fix on my local machine by unplugging the microphone while listening to it.