Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version v1.13.0 of monetize currently detects limited currency symbols. For example:
Expected behavior:
Current behavior:
Proposed Solution
The
Money::Currency.table
can be used to retrieve the list of currency symbols. In cases where symbols are repeated, thedisambiguate_symbol
can be used as the symbol. However, this solution has some limitations:To address these limitations, such symbols will be ignored during parsing. Additionally, any problematic symbols can be added to a list of ignored symbols to prevent issues. This can be a starting point but can be refined further to handle more cases and support additional symbols in the future.