Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates to Biome and pnpm from Rome and yarn #89

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Migrates to Biome and pnpm from Rome and yarn #89

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfaabcc
Update schema and dependencies to Biome 1.9.4
Royal-lobster Oct 25, 2024
f9e8022
Update biome format and biome check commands. Fix styling in SectionH…
Royal-lobster Oct 25, 2024
459b403
Refactor component imports to use "type" for better type checking
Royal-lobster Oct 25, 2024
f29ae9a
Refactor message removal logic in useCurrentChat hook
Royal-lobster Oct 25, 2024
cbada5b
Update release and release:cli scripts to use pnpm
Royal-lobster Oct 25, 2024
02097a0
Update workflow for lint checks and npm release
Royal-lobster Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rome.json → biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"$schema": "./node_modules/rome/configuration_schema.json",
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
"useIgnoreFile": false
},
"organizeImports": {
"enabled": false
},
Expand All @@ -10,7 +15,6 @@
"enabled": true,
"formatWithErrors": false,
"indentStyle": "space",
"indentSize": 2,
"lineWidth": 80
},
"linter": {
Expand All @@ -36,7 +40,6 @@
"javascript": {
"formatter": {
"quoteStyle": "single",
"trailingComma": "all",
"semicolons": "asNeeded"
}
}
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"preview": "vite preview",
"release": "yarn build && publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
"release:cli": "yarn build && dotenv -e .env -- publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update remaining yarn commands for pnpm migration.

As part of the migration from yarn to pnpm, these scripts still reference yarn commands:

-    "release": "yarn build && publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
-    "release:cli": "yarn build && dotenv -e .env -- publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
+    "release": "pnpm build && publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
+    "release:cli": "pnpm build && dotenv -e .env -- publish-extension --chrome-zip \"artifacts/chrome.zip\" --chrome-extension-id \"$CHROME_EXTENSION_ID\" --chrome-client-id \"$CHROME_CLIENT_ID\" --chrome-client-secret \"$CHROME_CLIENT_SECRET\" --chrome-refresh-token \"$CHROME_REFRESH_TOKEN\"",
-    "lint:fix": "yarn lint --apply"
+    "lint:fix": "pnpm lint --apply"

Also applies to: 23-23

"format": "rome format . --write",
"lint": "rome check .",
"format": "biome format . --write",
"lint": "biome check .",
"flush": "rm -rf artifacts/ dist/",
"lint:fix": "yarn lint --apply"
},
Expand Down Expand Up @@ -53,6 +53,7 @@
"webextension-polyfill": "^0.10.0"
},
"devDependencies": {
"@biomejs/biome": "1.9.4",
"@changesets/cli": "^2.26.1",
"@crxjs/vite-plugin": "^2.0.0-beta.15",
"@types/chrome": "^0.0.213",
Expand All @@ -66,7 +67,6 @@
"dotenv-cli": "^7.3.0",
"postcss": "^8.4.21",
"publish-browser-extension": "^1.4.1",
"rome": "12.0.0",
"tailwindcss": "^3.3.5",
"typescript": "^4.9.5",
"vite": "^4.1.1",
Expand Down
Loading
Loading