Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve existing lunacolors guide #331

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Naadiyaar
Copy link


  • I have reviewed CONTRIBUTING.md.
  • My commits and title use the Conventional Commit format.
  • I have documented changes and additions in the CHANGELOG.md.

Improved document formatting and mentioned 2 Lunacolors styles; reset and bright backgrounds.

Copy link
Member

@TorchedSammy TorchedSammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small markdown changes. make sure to actually read the contributing.md and make your commits conventional and PR title.

@Naadiyaar Naadiyaar changed the title Improve Lunacolors.md docs: improve existing lunacolors guide Dec 29, 2024
@Naadiyaar
Copy link
Author

Oh! I just realized it's possible to append suggested changes without a new commit.
Also about bad commit titles, apparently it's not possible to modify their message without making a new branch.

if you think all these will mess up the project's commit tree close this pr and I will make a new one.

@TorchedSammy
Copy link
Member

Also about bad commit titles, apparently it's not possible to modify their message without making a new branch.

amend them and force push

@Naadiyaar
Copy link
Author

Naadiyaar commented Dec 29, 2024

omg this is annoying. I forgot to update my patch-1 branch with the latest changes in the codebase.
I'll try again :(
sorry

edit: I believe it's ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants