Update context.cpp to avoid else after return #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update context.cpp to avoid else after return
Closed
|
Also contains #296 |
lyskov
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Hm... i do like the explicit else in https://github.com/RosettaCommons/binder/pull/292/files#diff-a991df2f19ad54fba2d1e4aa256a303fb097f489381a1adf8c5319726132c651L113 and i believe other changes now merged?
|
The rule is here: https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html But for the automatically generated code it also makes sense to reduce the size. |
|
Oh, i have not realized that this is inside generated code, - i see your point, - makes sense to me! |
lyskov
approved these changes
Apr 11, 2024
ldedier-gpfw
pushed a commit
to G-P-S/binder
that referenced
this pull request
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update context.cpp to avoid else after return