fix: room converter errors out when converting livechat room closed by the visitor #35107
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
KevLehman
approved these changes
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35107 +/- ##
========================================
Coverage 59.22% 59.22%
========================================
Files 2824 2824
Lines 68071 68071
Branches 15153 15153
========================================
Hits 40315 40315
Misses 24924 24924
Partials 2832 2832
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
KevLehman
requested changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If the closer of a livechat room is the visitor, the
closedByproperty of the room will contain the visitor's id, not the user's - which crashed the conversion from app format to core format as the converter was always trying to fetch a user from the DB.The behavior now checks for the
closerproperty to correctly assign the value to theclosedByproperty when converting back from the app.Issue(s)
Steps to test or reproduce
Further comments
Further changes will be done to types, however to make this a safely "backportable" PR, they will be done separately