-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove meteor startup & autorun from emojione #34989
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34989 +/- ##
===========================================
- Coverage 59.17% 59.16% -0.02%
===========================================
Files 2822 2822
Lines 68124 68104 -20
Branches 15149 15147 -2
===========================================
- Hits 40314 40294 -20
Misses 24978 24978
Partials 2832 2832
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about renaming it to useEmojiOne
and put it inside a hooks folder?
ARCH-1412