Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "Jump to Message" option for files #34180

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link

Proposed changes (including videos or screenshots)

Screencast.from.2024-12-15.12-27-57.webm

Issue(s)

RocketChat/feature-requests#915

Steps to test or reproduce

• Go to the All files option.
• Choose a file and click on its kebab menu.
• Select Jump to message.

@abirc8010 abirc8010 requested review from a team as code owners December 15, 2024 07:22
Copy link
Contributor

dionisio-bot bot commented Dec 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 15, 2024

⚠️ No Changeset found

Latest commit: 095a752

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@abirc8010
Copy link
Author

Currently, the feature works for messages sent after these changes are implemented, as I am adding a messageId attribute to the Uploadsmodel.
For files sent before these changes, which don’t have a messageId, the functionality can be achieved by searching for the file by its ID in threads and normal messages. However, I am uncertain about the performance impact of this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant