chore: deprecate from field from Email Bridge
#33713
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bf4b271 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33713 +/- ##
========================================
Coverage 75.01% 75.01%
========================================
Files 480 480
Lines 21000 21000
Branches 5329 5329
========================================
Hits 15754 15754
Misses 4619 4619
Partials 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
reviewed
Oct 22, 2024
d-gubert
approved these changes
Oct 22, 2024
d-gubert
reviewed
Oct 22, 2024
Comment on lines
+14
to
+18
| let { from } = email; | ||
| if (!from) { | ||
| this.orch.debugLog(`The app ${appId} didn't provide a from address, using the default one.`); | ||
| from = String(settings.get('From_Email')); | ||
| } |
There was a problem hiding this comment.
I would have gone with the good old email.from validation and assignment here, but you do you 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Deprecates the
fromfield from the apps.engine Email bridge to avoid misuse. Also, cloud workspaces require to have thefromthe same as defined in the settings, so we will get the value defined in theFrom_Emailsetting by default.Issue(s)
Steps to test or reproduce
Further comments