Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix meteor dynamic storage for E2EE client #33711

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Due to Meteor recently added Account session storage and the setting Accounts_ForgetUserSessionOnWindowClose, when enabled Meteor uses the session storage instead of local storage.

This was added in: #33356

The solution is to use the method Accounts.storageLocation to get the storage location

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-90

Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 9e0ac81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33711/
on branch gh-pages at 2024-10-22 19:12 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (fd5e54f) to head (9e0ac81).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33711   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21020    21020           
  Branches      5335     5335           
========================================
  Hits         15759    15759           
  Misses        4632     4632           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review October 22, 2024 20:27
@hugocostadev hugocostadev requested a review from a team as a code owner October 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant