Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add option to group model update operations together #33707

Draft
wants to merge 1 commit into
base: chore/expand-model-updater
Choose a base branch
from

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR adds the method updateOneById to the base model. By itself, this method simply executes an updateOne operation on the specified ID.

The PR also adds the hoardOperations method, which receives an id as param. This method will create an instance of the Updater class and associate it with the specified ID. After this, any calls to updateOneById will register the update operation on this Updater instance instead of executing an updateOne directly.

This makes it easier to change the existing codebase to start using the Updater class, as it can now be used inside callbacks and apps-engine events, bridges and converters without having to change the signature of anything.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 22, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 7d858d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33707/
on branch gh-pages at 2024-10-22 16:03 UTC

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (86bff91) to head (7d858d2).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           chore/expand-model-updater   #33707      +/-   ##
==============================================================
- Coverage                       74.99%   74.89%   -0.11%     
==============================================================
  Files                             480      480              
  Lines                           21073    21104      +31     
  Branches                         5358     5363       +5     
==============================================================
+ Hits                            15804    15806       +2     
- Misses                           4640     4669      +29     
  Partials                          629      629              
Flag Coverage Δ
unit 74.89% <6.45%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant