regression: Remove user from waiting queue when the key is set via updateGroupKey

[KevLehman]

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/E2EE2-89

Steps to test or reproduce

Further comments

This prevents the following edge case:

• User A logs in, user forgot keys
• User A creates a room, encrypted. As no keys, room stays in waiting queue state.
• User A resets their E2E keys (cause he forgot)
• User A logs in again, saves encryption keys.
• Room previously created starts processing and user sets the group keys as expected.
• User A invites User B to room
• User B is waiting keys.
• As user A reset their E2E keys, he's on the waitingQueue as well.
• User A cannot provide keys to User B so he cannot send encrypted messages.

(regression since prior to v7, the user creating the room suggested and accepted a key via async key exchange)

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 72351d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33696/
on branch gh-pages at 2024-10-21 19:53 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (ce283bf) to head (72351d3).

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #33696   +/-   ##
==============================================
  Coverage          74.97%   74.97%           
==============================================
  Files                480      480           
  Lines              21019    21019           
  Branches            5334     5334           
==============================================
  Hits               15760    15760           
  Misses              4630     4630           
  Partials             629      629           

Flag	Coverage Δ
unit	74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[ggazzo]

tests ? 👀

[KevLehman]

The thing with the tests is that this case shouldn't be possible. You should not be able to create rooms without your E2E keys setup in the first place (that's a diff issue).

So in reality there should be no way you hit this one. But I hit on candidate because the condition (not being able to create rooms without keys) is not working :/