Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RAC Style Library into Aurora #683

Open
wants to merge 69 commits into
base: development
Choose a base branch
from
Open

Conversation

HaSistrunk
Copy link
Member

@HaSistrunk HaSistrunk commented Sep 20, 2024

In progress...

fix #658
fix #555

  • Remove Bootstrap and AdminLTE styles
  • Remove moment.js for datatables (machine_file_upload_time data is already defined via models and views in the format we display it in, so unless I'm missing something we don't need to define a date format in the templates).
  • Use micromodal.js for modals instead of Bootstrap JS.
  • Update Datatables.js to version 2.1.8 and jquery 3.7.1, including updating Datatables implementation to align with more recent version. Evaluated alternatives with search and pagination options including Grid.js and Tabulator, but Datatables still seems to be the best option in terms of functionality and accessibility.
  • Pull in Datatables css, but customize to update table cell padding, the sort icon styles for better contrast, and adjust search/select input widths to work with RAC styles.
  • Use RAC styles header with dropdown menus instead of side navigation
  • Add standard public RAC footer and secondary footer with links to Docs Site Aurora user guide and digital transfer guide
  • Use HTML progress element instead of Bootstrap progressbar in transfer table.
  • Remove tab interface on /transfers page
  • Replace /appraise page transfer details modal with a link in the table to the transfer details page.
  • Remove pointer row script that allowed users to select an entire row as a link. Hard to make that work with assistive tech. Replaced with a value in table rows that serves as a link to more details.
  • Implement a tablist with associated tablist.js script adapted from the ARIA Authoring Practices Guide .
  • Improve alert pattern for aria-live announcements and to make all alerts manually dismissible so that they do not disappear without user action (both for improved accessibility).
  • Implement focus management when things are deleted in the DOM.
  • Fix delete_object_js script for Bagit and Rights org tables so that "there are no existing..." paragraph appears when table is deleted.
  • Restructure BagIt Profile creation form to use fieldsets (checkboxes and radio buttons) instead of multiple select inputs for certain form fields.
  • Simplify dashboard on homepage to remove chart.js, but still include useful data and add a hero with cta links.

Style Library update suggestions:

  • Different sized badges. We need a bigger one for these kind of status indications
  • Different colored badges.? It might be nice to have a standard green, red, and yellow to use.
  • Add btn--xs for buttons in a table (just less padding, don't make font smaller)
  • Improve dismissable alert button hover and focus styles.
  • Consider making table and summary list component text sans serif.
  • Add a blue version of nav-center header navigation menu
  • Standard form help text font is too small, and the labels are also quite small (14px). Maybe this tiny text only made sense in DIMES request modals and doesn't work as well in other contexts?
  • Add help text and error stories to checkbox component
  • Add form component for radio button
  • Add a margin-top of 5px for form help text. It's too close to the input
  • Make summary list component more responsive (consider collapsing the value below the key instead of side-by-side on large screens/high zoom)

Other considerations

  • We have implemented Datatables serverside in Aurora. If we anticipate 1000s of rows of data (which we may, over time!) this makes sense. Otherwise, I'm not sure we need that and it could make maintaining local Datatables functionality easier to use a client side implementation. I haven't changed the implementation here, though. Could be worth revisiting as part of issue Transfer table does not sort sizes correctly #646 .

@HaSistrunk HaSistrunk marked this pull request as ready for review November 15, 2024 17:03
@HaSistrunk
Copy link
Member Author

@helrond as discussed, help getting the bag-it forms switched from multiple select inputs to checkboxes would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants